Skip to content

CustomElementRegistry.prototype.initialize upgrades already initialized elements #56132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
annevk merged 2 commits into from
Nov 20, 2025
Merged

CustomElementRegistry.prototype.initialize upgrades already initialized elements #56132

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1b2914
CustomElementRegistry.prototype.initialize upgrades already initializ…
annevk Nov 20, 2025
d136436
Update scoped-registry-initialize-upgrades.html
annevk Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 23 additions & 3 deletions custom-elements/registries/scoped-registry-initialize-upgrades.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
assert_equals(element.customElementRegistry, null);
registry.initialize(element);
assert_equals(element.customElementRegistry, registry);
}, `${title}: customElementRegistry.prototype.initialize should upgrade the element given to the first argument`);
}, `${title}: CustomElementRegistry.prototype.initialize should upgrade the element given to the first argument`);

test(() => {
const doc = makeDocument();
Expand Down Expand Up @@ -49,7 +49,7 @@
assert_equals(registryInConstructor.length, 2);
assert_equals(registryInConstructor[0], registry);
assert_equals(registryInConstructor[1], registry);
}, `${title}: customElementRegistry.prototype.initialize should upgrade elements in tree order`);
}, `${title}: CustomElementRegistry.prototype.initialize should upgrade elements in tree order`);

test(() => {
const doc1 = makeDocument();
Expand Down Expand Up @@ -78,13 +78,33 @@
assert_true(undefinedElement1 instanceof ABElement);
assert_equals(undefinedElement2.customElementRegistry, registry2);
assert_equals(undefinedElement2.__proto__.constructor.name, 'HTMLElement');
}, `${title}: customElementRegistry.prototype.initialize only upgrades elements beloning to the registry`);
}, `${title}: CustomElementRegistry.prototype.initialize only upgrades elements beloning to the registry`);
}

runTest('Document', () => new Document);
runTest('HTMLDocument', () => document.implementation.createHTMLDocument());
runTest('XHTMLDocument', () => document.implementation.createDocument('http://www.w3.org/1999/xhtml', 'html', null));

test(() => {
class ABElement extends HTMLElement { };
const registry = new CustomElementRegistry;

const element = document.createElement('a-b', { customElementRegistry: registry });
assert_equals(element.customElementRegistry, registry);
assert_equals(element.__proto__.constructor.name, 'HTMLElement');
assert_false(element instanceof ABElement);

registry.define('a-b', ABElement);
assert_equals(element.customElementRegistry, registry);
assert_equals(element.__proto__.constructor.name, 'HTMLElement');
assert_false(element instanceof ABElement);

registry.initialize(element);
assert_equals(element.customElementRegistry, registry);
assert_equals(element.__proto__.constructor.name, 'ABElement');
assert_true(element instanceof ABElement);
}, `CustomElementRegistry.prototype.initialize upgrades already initialized elements`);

</script>
</body>
</html>