CustomElementRegistry.prototype.initialize upgrades already initialized elements #56132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
TakayoshiKochi,
hayatoito,
kojiishi and
snuggs
6 tasks
rniwa
approved these changes
Nov 20, 2025
annevk
added a commit
to whatwg/html
that referenced
this pull request
Nov 21, 2025
CustomElementRegistry's upgrade() wasn't adjusted for scoped registries and we decided that initialize() should upgrade as well (but not into shadow trees as upgrade() does). The initialize() design here favors a single tree traversal for setting the registry and then upgrading the element. Tests: - web-platform-tests/wpt#56034 - web-platform-tests/wpt#56132 Fixes #11858 and fixes #11908.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For whatwg/html#11913.