test.py: only run *.gen.sh scripts actually generated during that run
#1488
+51
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, a previously generated `*.gen.sh` file will still be run even if it's no longer supposed to be generated (and isn't anymore).
We search for and find non-generated scripts (`.sh`, but not `.gen.sh`), whereas we record all generated scripts, which we then combine to get all scripts.
ahomescu
approved these changes
Dec 3, 2025
ahomescu
reviewed
Dec 3, 2025
| self.dir = directory | ||
| self.conf_file = os.path.join(directory, CONF_YML) | ||
| self.name = os.path.basename(directory) | ||
| def __init__(self, directory: Path, generated_scripts: set[Path]): |
Contributor
There was a problem hiding this comment.
I think the error you're getting is because you're getting all the scripts in generated_scripts here, not just the ones in the current directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*.gen.shscripts actually generated during that run c2rust-testsuite#29.Otherwise, a previously generated
*.gen.shfile will still be run even if it's no longer supposed to be generated (and isn't anymore).