test.py: only run *.gen.sh scripts actually generated during that run
#29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkysen
force-pushed
the
kkysen/only-run-generated-gen.sh-scripts
branch
from
20cabfa to
d3ff86f
Compare
fw-immunant
reviewed
Nov 17, 2025
fw-immunant
reviewed
Nov 17, 2025
Contributor
Author
|
Ugh, something got messed up in how the script is run/Python version. |
ahomescu
reviewed
Nov 19, 2025
ahomescu
approved these changes
Nov 20, 2025
kkysen
force-pushed
the
kkysen/only-run-generated-gen.sh-scripts
branch
from
48065a0 to
b3a64d0
Compare
Contributor
|
@kkysen You should move this to the main c2rust repo. |
Otherwise, a previously generated `*.gen.sh` file will still be run even if it's no longer supposed to be generated (and isn't anymore).
We search for and find non-generated scripts (`.sh`, but not `.gen.sh`), whereas we record all generated scripts, which we then combine to get all scripts.
kkysen
force-pushed
the
kkysen/only-run-generated-gen.sh-scripts
branch
from
b3a64d0 to
ebe83e4
Compare
Contributor
Author
kkysen
added a commit
to immunant/c2rust
that referenced
this pull request
Dec 8, 2025
…un (#1488) * Moving immunant/c2rust-testsuite#29. Otherwise, a previously generated `*.gen.sh` file will still be run even if it's no longer supposed to be generated (and isn't anymore).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, a previously generated
*.gen.shfile will still be run even if it's no longer supposed to be generated (and isn't anymore).