transpile: Translate null pointers with ptr::null[_mut]
#1479
Conversation
Rua
force-pushed
the
null_ptr
branch
2 times, most recently
from
88f376c to
4ae5c83
Compare
|
The testsuite is crashing with a stack overflow. Since all this PR does is replace a cast with a function call, is that particular test nesting calls so deeply that a few extra is making it overrun? |
|
This has happened before in the lua test, I made immunant/c2rust-testsuite#37 to compile it in release mode so it doesn't use as much stack. |
kkysen
left a comment
kkysen
left a comment
There was a problem hiding this comment.
LGTM! Thanks for this; it's very nice to have a provenance correct translation, and also miri won't complain about this stuff anymore if we're looking for other more serious issues.
| pub static mut scope: *mut Scope = &{ | ||
| let mut init = Scope { | ||
| next: 0 as *const Scope as *mut Scope, | ||
| next: ::core::ptr::null::<Scope>() as *mut Scope, |
There was a problem hiding this comment.
We probably want to fix how we're generating this so that we just use null_mut directly, but this is fine for now, and still technically correct.
There was a problem hiding this comment.
Oh wait, I see why it's happening now. Nevermind. Nice fix.
3 participants
convert_pointerinto two functions for easier reuse #1478.std::ptr::null_mut::<T>()instead of0 as *mut T#202.This is more idiomatic, and is also necessary for supporting strict(er) provenance in the future.