transpile: Split off new pointers.rs module #1495
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working with pointer-related stuff, I found that related code was kinda scattered all over, making it difficult to find at times. This creates a new pointers.rs module, moves some existing functions there, and creates new functions to wrap some other bits of code. I've tried to not make too many semantic changes.
In
convert_assignment_operator_with_rhsthere was a bit of dead code that I removed. SinceAssignAddandAssignSubtractare handled by the match arms, theifthat checks for them below a second time wasn't doing anything (and it did the same thing anyway).