Skip to content

Conversation

@lumirlumir
Copy link
Member

@lumirlumir lumirlumir commented Dec 2, 2025

Prerequisites checklist

What is the purpose of this pull request?

This PR was motivated by eslint/json#187 (comment).

Currently, when updating @eslint/core to v1.0.0, CI fails because @eslint/[email protected] does not match ESLint v9

@eslint/[email protected] includes type information for ESLint v10, which causes the type mismatch.

So, I've updated ESLint to >=10.0.0-alpha.0 <10.0.0 || ^10.0.1. (Ref: https://github.com/eslint/eslint/blob/main/packages/eslint-config-eslint/package.json#L66)


When I update ESLint to >=10.0.0-alpha.0 <10.0.0 || ^10.0.1, the following error occurs, so I added the legacy-peer-deps option to .npmrc.

This change follows the approach in eslint/eslint#20281

image

What changes did you make? (Give an overview)

In this PR, I've updated @eslint/core, add legacy-peer-deps, and use ESLint v10 pre-release.

Related Issues

Ref: #327, eslint/json#187 (comment), eslint/eslint#20281

Is there anything you'd like reviewers to focus on?

N/A

@lumirlumir
Copy link
Member Author

Counterpart PR in eslint/json: eslint/json#190

"license": "Apache-2.0",
"dependencies": {
"@eslint/core": "^0.17.0",
"@eslint/core": "^1.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as eslint/json#190 (comment). We can clarify there, just wanted to leave a note here as well so that we don't merge until this is clarified.

@lumirlumir lumirlumir added the accepted There is consensus among the team that this change meets the criteria for inclusion label Dec 7, 2025
@lumirlumir lumirlumir moved this from Needs Triage to Implementing in Triage Dec 7, 2025
Copilot AI review requested due to automatic review settings December 7, 2025 12:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates dependencies to support ESLint v10 pre-release versions, motivated by type mismatches when upgrading @eslint/core to v1.0.0. The changes prepare the package for ESLint v10 compatibility by updating both the core library and ESLint itself, while temporarily using legacy-peer-deps to handle peer dependency conflicts during the transition period.

  • Updated @eslint/core from ^0.17.0 to ^1.0.0 to get ESLint v10 type information
  • Updated ESLint dev dependency to use v10 pre-release version range
  • Added legacy-peer-deps = true to .npmrc as temporary workaround for peer dependency conflicts

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
package.json Updates @eslint/core to v1.0.0 and ESLint to v10 pre-release range
.npmrc Adds legacy-peer-deps = true flag with TODO comment for post-v10 release removal

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lumirlumir
Copy link
Member Author

Per the suggestions from eslint/json#190, I've updated types.test.ts to use the Plugin type instead of ESLint.Plugin in eslint/json@d7d3b71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion chore

Projects

Status: Implementing

Development

Successfully merging this pull request may close these issues.

3 participants