-
-
Notifications
You must be signed in to change notification settings - Fork 32
chore: update @eslint/core, add legacy-peer-deps, and use ESLint v10
#337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Counterpart PR in eslint/json: eslint/json#190 |
| "license": "Apache-2.0", | ||
| "dependencies": { | ||
| "@eslint/core": "^0.17.0", | ||
| "@eslint/core": "^1.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question as eslint/json#190 (comment). We can clarify there, just wanted to leave a note here as well so that we don't merge until this is clarified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates dependencies to support ESLint v10 pre-release versions, motivated by type mismatches when upgrading @eslint/core to v1.0.0. The changes prepare the package for ESLint v10 compatibility by updating both the core library and ESLint itself, while temporarily using legacy-peer-deps to handle peer dependency conflicts during the transition period.
- Updated
@eslint/corefrom ^0.17.0 to ^1.0.0 to get ESLint v10 type information - Updated ESLint dev dependency to use v10 pre-release version range
- Added
legacy-peer-deps = trueto.npmrcas temporary workaround for peer dependency conflicts
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Updates @eslint/core to v1.0.0 and ESLint to v10 pre-release range |
| .npmrc | Adds legacy-peer-deps = true flag with TODO comment for post-v10 release removal |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Per the suggestions from eslint/json#190, I've updated |
Prerequisites checklist
What is the purpose of this pull request?
This PR was motivated by eslint/json#187 (comment).
Currently, when updating
@eslint/coreto v1.0.0, CI fails because@eslint/[email protected]does not match ESLint v9@eslint/[email protected]includes type information for ESLint v10, which causes the type mismatch.So, I've updated ESLint to
>=10.0.0-alpha.0 <10.0.0 || ^10.0.1. (Ref: https://github.com/eslint/eslint/blob/main/packages/eslint-config-eslint/package.json#L66)When I update ESLint to
>=10.0.0-alpha.0 <10.0.0 || ^10.0.1, the following error occurs, so I added thelegacy-peer-depsoption to.npmrc.This change follows the approach in eslint/eslint#20281
What changes did you make? (Give an overview)
In this PR, I've updated
@eslint/core, addlegacy-peer-deps, and use ESLint v10 pre-release.Related Issues
Ref: #327, eslint/json#187 (comment), eslint/eslint#20281
Is there anything you'd like reviewers to focus on?
N/A