Skip to content

Conversation

@labkey-tchad
Copy link
Member

Rationale

I updated a test to use WebTestHelper.buildURL to create a URL and it started failing because the URL query isn't properly encoded. The page just says "Invalid characters in request." and the test fails with:

java.lang.AssertionError: Incorrect response code expected:<404> but was:<200>
  at org.junit.Assert.fail(Assert.java:89)
  at org.junit.Assert.failNotEquals(Assert.java:835)
  at org.junit.Assert.assertEquals(Assert.java:647)
  at org.labkey.test.tests.list.ListTest.testCustomViews(ListTest.java:691)

Related Pull Requests

Changes

  • Encode URL query parameters when building a URL

Copy link
Contributor

@labkey-chrisj labkey-chrisj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope this works!

@labkey-tchad labkey-tchad merged commit 50eab2b into develop Dec 4, 2024
1 of 2 checks passed
@labkey-tchad labkey-tchad deleted the fb_urlQueryEncoding branch December 4, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants