Handle unusual query encoding in link href #6137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-chrisj
approved these changes
Dec 9, 2024
| Maps.of("datasetId", 5018, | ||
| "Dataset.ParticipantId~in", PTID_NO_ALIAS + ";" + PTID_NEW_2)); | ||
| Maps.of("datasetId", 5018, "Dataset.ParticipantId~in", PTID_NO_ALIAS + ";" + PTID_NEW_2)) | ||
| .replace("%7E", "~"); // '~' isn't encoded in href |
Contributor
There was a problem hiding this comment.
is this substitution generalizable for other use cases? Asking to prompt the question whether this should be done in a helper vs. in test code
Member
Author
There was a problem hiding this comment.
I wouldn't count on it. There are a lot of "valid" encodings and I doubt we're consistent on the product side. We should probably avoid finding elements by href attribute like this. It would be preferable to grab the link by some other means and decode it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
The link this test is checking doesn't encode a
~. Need to adjust the expectedhrefto account for this.Also, fixing some invalid Locators that are used for validation here.
Related Pull Requests
Changes