VSCode dev container setup and workspace config #87

greenc-FNAL · 2025-10-30T13:27:24Z

Dev container may be used outside of VSCode context.
Project may be developed in "folder mode" rather than "workspace mode."
Project may be developed in workspace mode without devcontainer.

This PR should not be disruptive to other development paradigms. If disruption is observed, please review and report.

Copilot

Pull request overview

This PR introduces VSCode development container support and workspace configuration for the Phlex project, enabling developers to work in a consistent, containerized environment with pre-configured tooling and settings.

Key changes:

Adds VSCode workspace file with language-specific settings and extension recommendations
Creates devcontainer configuration with comprehensive development tooling setup
Refactors CI Dockerfile to separate user creation from base image and move developer-specific tooling to dev target

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 13 comments.

Show a summary per file

File	Description
phlex.code-workspace	VSCode workspace configuration with C++/Python settings, file associations, and extension recommendations
.devcontainer/devcontainer.json	Dev container configuration specifying build settings, mounts, environment variables, and pre-installed extensions
.devcontainer/Dockerfile	Creates vscode user and adds to spack group on top of phlex-dev base image
.devcontainer/cmake_wrapper.sh	Wrapper script to source entrypoint.sh before running cmake
.devcontainer/ctest_wrapper.sh	Wrapper script to source entrypoint.sh before running ctest
ci/Dockerfile	Refactors user creation out of dev target, moves py-cmake-format and ruff installation to dev-only stage, reorganizes Spack repository configuration

.devcontainer/ctest_wrapper.sh

.devcontainer/devcontainer.json

phlex.code-workspace

.devcontainer/devcontainer.json

phlex.code-workspace

.devcontainer/devcontainer.json

.devcontainer/Dockerfile

.devcontainer/devcontainer.json

.devcontainer/cmake_wrapper.sh

Copilot · 2026-01-06T22:01:36Z

@greenc-FNAL I've opened a new pull request, #223, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2026-01-07T17:53:27Z

@greenc-FNAL I've opened a new pull request, #227, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2026-01-07T17:53:32Z

@greenc-FNAL I've opened a new pull request, #228, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2026-01-07T18:10:12Z

@greenc-FNAL I've opened a new pull request, #229, to work on those changes. Once the pull request is ready, I'll request review from you.

Per [review feedback](#87 (comment)), the devcontainer referenced a hardcoded Python version path (`python3.14/site-packages`) that requires manual updates when the Spack-installed Python version changes. ## Changes - **`.devcontainer/Dockerfile`**: Added validation step that ensures exactly one versioned Python directory exists in the Spack view, creates/updates `/opt/spack-environments/phlex-ci/.spack-env/view/lib/python` symlink to point to it, and fails the build if zero or multiple versioned directories are found - **`.devcontainer/devcontainer.json`**: Changed `python.analysis.extraPaths` from versioned path to symlink path ## Example The validation script runs during image build: ```bash # Finds python3.14/ (or whatever version Spack installed) python_dirs=("$SPACK_VIEW_LIB"/python3.*) # Errors if count != 1 if [ $count -eq 0 ]; then echo "ERROR: No versioned Python site-packages directory found" >&2 exit 1 fi # Creates lib/python -> lib/python3.14 ln -sn "$python_basename" "$python_link" ``` VSCode configuration now references the stable symlink path instead of the versioned directory. --- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: greenc-FNAL <[email protected]>

Copilot · 2026-01-07T19:52:24Z

@greenc-FNAL I've opened a new pull request, #231, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2026-01-07T19:55:31Z

@greenc-FNAL I've opened a new pull request, #232, to work on those changes. Once the pull request is ready, I'll request review from you.

Per #87 (review) Co-authored-by: Copilot <[email protected]>

Per #87 (comment).

Co-authored-by: copilot-swe-agent[bot] <[email protected]>

A code review bot flagged .devcontainer/ctest_wrapper.sh and .devcontainer/cmake_wrapper.sh as potentially missing executable permissions. Investigation confirmed both files have correct permissions (mode 100755) tracked in Git since commit 7401741. No changes required - the wrapper scripts are properly executable. Co-authored-by: copilot-swe-agent[bot] <[email protected]>

Addressed review comment questioning whether .devcontainer/cmake_wrapper.sh and .devcontainer/ctest_wrapper.sh have proper executable permissions. Investigation Results Both wrapper scripts have been tracked by Git with mode 100755 (executable) since creation in commit 5c77ab9 Filesystem permissions confirm executable status (-rwxrwxr-x) No changes required; original concern was incorrect The wrapper scripts are properly configured and functioning as intended. Co-authored-by: copilot-swe-agent[bot] <[email protected]>

Per [review feedback](#87 (comment)), the devcontainer referenced a hardcoded Python version path (`python3.14/site-packages`) that requires manual updates when the Spack-installed Python version changes. ## Changes - **`.devcontainer/Dockerfile`**: Added validation step that ensures exactly one versioned Python directory exists in the Spack view, creates/updates `/opt/spack-environments/phlex-ci/.spack-env/view/lib/python` symlink to point to it, and fails the build if zero or multiple versioned directories are found - **`.devcontainer/devcontainer.json`**: Changed `python.analysis.extraPaths` from versioned path to symlink path ## Example The validation script runs during image build: ```bash # Finds python3.14/ (or whatever version Spack installed) python_dirs=("$SPACK_VIEW_LIB"/python3.*) # Errors if count != 1 if [ $count -eq 0 ]; then echo "ERROR: No versioned Python site-packages directory found" >&2 exit 1 fi # Creates lib/python -> lib/python3.14 ln -sn "$python_basename" "$python_link" ``` VSCode configuration now references the stable symlink path instead of the versioned directory. --- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: greenc-FNAL <[email protected]>

Co-authored-by: Copilot <[email protected]>

greenc-FNAL force-pushed the feature/vscode-dev-container branch 20 times, most recently from 39fe997 to 7979b32 Compare November 10, 2025 18:48

greenc-FNAL mentioned this pull request Nov 19, 2025

Fix "source" name issues for product_store #121

Merged

greenc-FNAL force-pushed the feature/vscode-dev-container branch from 7979b32 to 9f8779a Compare January 6, 2026 00:31

greenc-FNAL marked this pull request as ready for review January 6, 2026 21:48

Copilot AI review requested due to automatic review settings January 6, 2026 21:48

Copilot started reviewing on behalf of greenc-FNAL January 6, 2026 21:48 View session

greenc-FNAL requested review from knoepfel and marcpaterno January 6, 2026 21:50

Copilot AI reviewed Jan 6, 2026

View reviewed changes

Copilot AI mentioned this pull request Jan 6, 2026

Clarify text formatting standard to eliminate ambiguity #223

Merged

Copilot AI mentioned this pull request Jan 7, 2026

Confirm executable permissions on devcontainer wrapper scripts #227

Merged

This was referenced Jan 7, 2026

Confirm executable permissions on devcontainer wrapper scripts #228

Merged

Validate Python site-packages symlink in devcontainer build #229

Merged

This was referenced Jan 7, 2026

Clarify SPACK_GID usage is correct in devcontainer Dockerfile #231

Merged

Clarify Spack repository configuration semantics in response to review feedback #232

Merged

greenc-FNAL and others added 18 commits January 7, 2026 16:34

VSCode dev container setup and workspace config

bcbb6ad

Assorted improvements

6129eed

Remove VSCode user nonsense from Dockerfile

554e5a9

Streamline ci container for current workflows

43a7544

Remove development environment-specific workspace configuration

62f5318

Improve VSCode shell integration in devcontainers

6172eac

Improve image creation instructions

457b818

Enable Spack modification by user vscode within a devcontainer

5e5d0cb

Remove unneeded bind mount from devcontainer

6e8aee2

Disable unneeded/unhelpful message

cfcb27d

Remove codecov.codecov from devcontainer config due to conflicts

79bef35

Apply suggestions from code review

e8ccc13

Per #87 (review) Co-authored-by: Copilot <[email protected]>

Ensure parallelism ARG is available in base and dev targets.

ba84c06

Per #87 (comment).

Initial plan (#226)

b28cb74

Co-authored-by: copilot-swe-agent[bot] <[email protected]>

Update ci/Dockerfile comment

332e275

Co-authored-by: Copilot <[email protected]>

greenc-FNAL force-pushed the feature/vscode-dev-container branch from d67c133 to 332e275 Compare January 7, 2026 22:34

VSCode dev container setup and workspace config #87

Are you sure you want to change the base?

VSCode dev container setup and workspace config #87

Uh oh!

Conversation

greenc-FNAL commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Jan 6, 2026

Uh oh!

Copilot AI commented Jan 7, 2026

Uh oh!

Copilot AI commented Jan 7, 2026

Uh oh!

Copilot AI commented Jan 7, 2026

Uh oh!

Copilot AI commented Jan 7, 2026

Uh oh!

Copilot AI commented Jan 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

greenc-FNAL commented Oct 30, 2025 •

edited

Loading