Clarify Spack repository configuration semantics in response to review feedback

[Copilot]

Addressed review comment questioning the use of $SPACK_REPO_ROOT for the spack repo set --destination command.

Context

The --destination argument in spack repo set has different semantics than the path argument in spack repo add:

• spack repo add <path>: registers a repository located at <path>
• spack repo set --destination <path> <name>: relocates repository <name> to <path>

Resolution

No code changes required. The current implementation correctly uses $SPACK_REPO_ROOT (/opt/spack-repos) for all repositories including builtin, consolidating them in a single location with appropriate group permissions for the spack group.

spack --timestamp repo add --scope site $SPACK_REPO_ROOT/phlex-spack-recipes/spack_repo/phlex
spack --timestamp repo add --scope site $SPACK_REPO_ROOT/fnal_art/spack_repo/fnal_art
spack --timestamp repo set --scope site --destination $SPACK_REPO_ROOT builtin

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[Copilot]

Copilot wasn't able to review any files in this pull request.