-
Notifications
You must be signed in to change notification settings - Fork 319
Added missing configuration of Spotless to buildSrc module.
#10085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AlexeyKuznetsov-DD
wants to merge
2
commits into
master
Choose a base branch
from
alexeyk/spotless-for-build-src
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 10 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~48547a9ec1, baseline=1.57.0-SNAPSHOT~a2f3c7a523
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.104 s) : 0, 1103835
Total [baseline] (8.763 s) : 0, 8762579
Agent [candidate] (1.107 s) : 0, 1106966
Total [candidate] (8.766 s) : 0, 8765709
section iast
Agent [baseline] (1.25 s) : 0, 1250398
Total [baseline] (9.497 s) : 0, 9496542
Agent [candidate] (1.249 s) : 0, 1248771
Total [candidate] (9.491 s) : 0, 9491485
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~48547a9ec1, baseline=1.57.0-SNAPSHOT~a2f3c7a523
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.475 ms) : 0, 1475
crashtracking [candidate] (1.478 ms) : 0, 1478
BytebuddyAgent [baseline] (691.577 ms) : 0, 691577
BytebuddyAgent [candidate] (694.359 ms) : 0, 694359
GlobalTracer [baseline] (264.443 ms) : 0, 264443
GlobalTracer [candidate] (264.643 ms) : 0, 264643
AppSec [baseline] (32.042 ms) : 0, 32042
AppSec [candidate] (31.864 ms) : 0, 31864
Debugger [baseline] (66.467 ms) : 0, 66467
Debugger [candidate] (66.592 ms) : 0, 66592
Remote Config [baseline] (637.075 µs) : 0, 637
Remote Config [candidate] (630.058 µs) : 0, 630
Telemetry [baseline] (8.718 ms) : 0, 8718
Telemetry [candidate] (8.78 ms) : 0, 8780
Flare Poller [baseline] (3.54 ms) : 0, 3540
Flare Poller [candidate] (3.596 ms) : 0, 3596
section iast
crashtracking [baseline] (1.477 ms) : 0, 1477
crashtracking [candidate] (1.477 ms) : 0, 1477
BytebuddyAgent [baseline] (838.191 ms) : 0, 838191
BytebuddyAgent [candidate] (836.039 ms) : 0, 836039
GlobalTracer [baseline] (237.96 ms) : 0, 237960
GlobalTracer [candidate] (238.529 ms) : 0, 238529
IAST [baseline] (34.753 ms) : 0, 34753
IAST [candidate] (29.552 ms) : 0, 29552
AppSec [baseline] (27.159 ms) : 0, 27159
AppSec [candidate] (32.498 ms) : 0, 32498
Debugger [baseline] (63.591 ms) : 0, 63591
Debugger [candidate] (63.264 ms) : 0, 63264
Remote Config [baseline] (537.064 µs) : 0, 537
Remote Config [candidate] (533.234 µs) : 0, 533
Telemetry [baseline] (8.337 ms) : 0, 8337
Telemetry [candidate] (8.311 ms) : 0, 8311
Flare Poller [baseline] (3.476 ms) : 0, 3476
Flare Poller [candidate] (3.442 ms) : 0, 3442
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~48547a9ec1, baseline=1.57.0-SNAPSHOT~a2f3c7a523
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.106 s) : 0, 1105686
Total [baseline] (10.657 s) : 0, 10657082
Agent [candidate] (1.106 s) : 0, 1106268
Total [candidate] (10.688 s) : 0, 10688011
section appsec
Agent [baseline] (1.288 s) : 0, 1288188
Total [baseline] (11.048 s) : 0, 11047555
Agent [candidate] (1.289 s) : 0, 1288944
Total [candidate] (11.026 s) : 0, 11026222
section iast
Agent [baseline] (1.248 s) : 0, 1248187
Total [baseline] (11.178 s) : 0, 11178322
Agent [candidate] (1.257 s) : 0, 1257294
Total [candidate] (11.158 s) : 0, 11158212
section profiling
Agent [baseline] (1.233 s) : 0, 1232685
Total [baseline] (10.944 s) : 0, 10944245
Agent [candidate] (1.246 s) : 0, 1246285
Total [candidate] (10.975 s) : 0, 10975254
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~48547a9ec1, baseline=1.57.0-SNAPSHOT~a2f3c7a523
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.474 ms) : 0, 1474
crashtracking [candidate] (1.48 ms) : 0, 1480
BytebuddyAgent [baseline] (692.443 ms) : 0, 692443
BytebuddyAgent [candidate] (692.367 ms) : 0, 692367
GlobalTracer [baseline] (264.521 ms) : 0, 264521
GlobalTracer [candidate] (264.819 ms) : 0, 264819
AppSec [baseline] (31.923 ms) : 0, 31923
AppSec [candidate] (32.045 ms) : 0, 32045
Debugger [baseline] (67.603 ms) : 0, 67603
Debugger [candidate] (67.541 ms) : 0, 67541
Remote Config [baseline] (625.888 µs) : 0, 626
Remote Config [candidate] (638.484 µs) : 0, 638
Telemetry [baseline] (8.728 ms) : 0, 8728
Telemetry [candidate] (8.837 ms) : 0, 8837
Flare Poller [baseline] (3.543 ms) : 0, 3543
Flare Poller [candidate] (3.642 ms) : 0, 3642
section appsec
crashtracking [baseline] (1.467 ms) : 0, 1467
crashtracking [candidate] (1.493 ms) : 0, 1493
BytebuddyAgent [baseline] (732.29 ms) : 0, 732290
BytebuddyAgent [candidate] (732.208 ms) : 0, 732208
GlobalTracer [baseline] (240.74 ms) : 0, 240740
GlobalTracer [candidate] (241.099 ms) : 0, 241099
IAST [baseline] (24.723 ms) : 0, 24723
IAST [candidate] (24.636 ms) : 0, 24636
AppSec [baseline] (174.951 ms) : 0, 174951
AppSec [candidate] (175.318 ms) : 0, 175318
Debugger [baseline] (65.537 ms) : 0, 65537
Debugger [candidate] (65.735 ms) : 0, 65735
Remote Config [baseline] (729.751 µs) : 0, 730
Remote Config [candidate] (734.578 µs) : 0, 735
Telemetry [baseline] (8.972 ms) : 0, 8972
Telemetry [candidate] (9.069 ms) : 0, 9069
Flare Poller [baseline] (3.652 ms) : 0, 3652
Flare Poller [candidate] (3.636 ms) : 0, 3636
section iast
crashtracking [baseline] (1.479 ms) : 0, 1479
crashtracking [candidate] (1.47 ms) : 0, 1470
BytebuddyAgent [baseline] (835.092 ms) : 0, 835092
BytebuddyAgent [candidate] (842.25 ms) : 0, 842250
GlobalTracer [baseline] (238.247 ms) : 0, 238247
GlobalTracer [candidate] (239.412 ms) : 0, 239412
IAST [baseline] (31.953 ms) : 0, 31953
IAST [candidate] (32.32 ms) : 0, 32320
AppSec [baseline] (29.966 ms) : 0, 29966
AppSec [candidate] (29.698 ms) : 0, 29698
Debugger [baseline] (64.075 ms) : 0, 64075
Debugger [candidate] (64.598 ms) : 0, 64598
Remote Config [baseline] (544.877 µs) : 0, 545
Remote Config [candidate] (554.774 µs) : 0, 555
Telemetry [baseline] (8.356 ms) : 0, 8356
Telemetry [candidate] (8.417 ms) : 0, 8417
Flare Poller [baseline] (3.432 ms) : 0, 3432
Flare Poller [candidate] (3.517 ms) : 0, 3517
section profiling
crashtracking [baseline] (1.427 ms) : 0, 1427
crashtracking [candidate] (1.451 ms) : 0, 1451
BytebuddyAgent [baseline] (732.662 ms) : 0, 732662
BytebuddyAgent [candidate] (742.2 ms) : 0, 742200
GlobalTracer [baseline] (221.583 ms) : 0, 221583
GlobalTracer [candidate] (223.458 ms) : 0, 223458
AppSec [baseline] (32.247 ms) : 0, 32247
AppSec [candidate] (32.513 ms) : 0, 32513
Debugger [baseline] (66.134 ms) : 0, 66134
Debugger [candidate] (66.639 ms) : 0, 66639
Remote Config [baseline] (641.11 µs) : 0, 641
Remote Config [candidate] (655.561 µs) : 0, 656
Telemetry [baseline] (8.858 ms) : 0, 8858
Telemetry [candidate] (8.844 ms) : 0, 8844
Flare Poller [baseline] (6.121 ms) : 0, 6121
Flare Poller [candidate] (7.035 ms) : 0, 7035
ProfilingAgent [baseline] (93.863 ms) : 0, 93863
ProfilingAgent [candidate] (93.731 ms) : 0, 93731
Profiling [baseline] (94.433 ms) : 0, 94433
Profiling [candidate] (94.305 ms) : 0, 94305
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 3 performance regressions! Performance is the same for 16 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~48547a9ec1, baseline=1.57.0-SNAPSHOT~a2f3c7a523
dateFormat X
axisFormat %s
section baseline
no_agent (1.239 ms) : 1226, 1251
. : milestone, 1239,
iast (3.281 ms) : 3234, 3328
. : milestone, 3281,
iast_FULL (5.676 ms) : 5619, 5733
. : milestone, 5676,
iast_GLOBAL (3.69 ms) : 3636, 3743
. : milestone, 3690,
profiling (2.052 ms) : 2035, 2070
. : milestone, 2052,
tracing (1.805 ms) : 1790, 1820
. : milestone, 1805,
section candidate
no_agent (1.198 ms) : 1186, 1209
. : milestone, 1198,
iast (3.168 ms) : 3124, 3212
. : milestone, 3168,
iast_FULL (5.905 ms) : 5846, 5964
. : milestone, 5905,
iast_GLOBAL (3.585 ms) : 3525, 3645
. : milestone, 3585,
profiling (1.896 ms) : 1881, 1912
. : milestone, 1896,
tracing (1.799 ms) : 1784, 1815
. : milestone, 1799,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~48547a9ec1, baseline=1.57.0-SNAPSHOT~a2f3c7a523
dateFormat X
axisFormat %s
section baseline
no_agent (16.774 ms) : 16610, 16938
. : milestone, 16774,
appsec (18.666 ms) : 18477, 18856
. : milestone, 18666,
code_origins (17.5 ms) : 17328, 17672
. : milestone, 17500,
iast (17.91 ms) : 17732, 18088
. : milestone, 17910,
profiling (18.672 ms) : 18487, 18857
. : milestone, 18672,
tracing (17.599 ms) : 17424, 17774
. : milestone, 17599,
section candidate
no_agent (18.773 ms) : 18580, 18966
. : milestone, 18773,
appsec (18.525 ms) : 18337, 18712
. : milestone, 18525,
code_origins (17.486 ms) : 17314, 17658
. : milestone, 17486,
iast (17.741 ms) : 17565, 17917
. : milestone, 17741,
profiling (20.272 ms) : 20069, 20475
. : milestone, 20272,
tracing (17.551 ms) : 17380, 17722
. : milestone, 17551,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~48547a9ec1, baseline=1.57.0-SNAPSHOT~a2f3c7a523
dateFormat X
axisFormat %s
section baseline
no_agent (1.476 ms) : 1464, 1487
. : milestone, 1476,
appsec (3.633 ms) : 3419, 3848
. : milestone, 3633,
iast (2.206 ms) : 2142, 2270
. : milestone, 2206,
iast_GLOBAL (2.251 ms) : 2187, 2315
. : milestone, 2251,
profiling (2.07 ms) : 2016, 2123
. : milestone, 2070,
tracing (2.047 ms) : 1996, 2098
. : milestone, 2047,
section candidate
no_agent (1.48 ms) : 1468, 1492
. : milestone, 1480,
appsec (2.447 ms) : 2396, 2498
. : milestone, 2447,
iast (2.206 ms) : 2142, 2270
. : milestone, 2206,
iast_GLOBAL (2.255 ms) : 2191, 2320
. : milestone, 2255,
profiling (2.08 ms) : 2026, 2133
. : milestone, 2080,
tracing (2.036 ms) : 1986, 2087
. : milestone, 2036,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~48547a9ec1, baseline=1.57.0-SNAPSHOT~a2f3c7a523
dateFormat X
axisFormat %s
section baseline
no_agent (14.954 s) : 14954000, 14954000
. : milestone, 14954000,
appsec (14.831 s) : 14831000, 14831000
. : milestone, 14831000,
iast (18.606 s) : 18606000, 18606000
. : milestone, 18606000,
iast_GLOBAL (18.039 s) : 18039000, 18039000
. : milestone, 18039000,
profiling (14.841 s) : 14841000, 14841000
. : milestone, 14841000,
tracing (14.603 s) : 14603000, 14603000
. : milestone, 14603000,
section candidate
no_agent (15.046 s) : 15046000, 15046000
. : milestone, 15046000,
appsec (14.707 s) : 14707000, 14707000
. : milestone, 14707000,
iast (18.457 s) : 18457000, 18457000
. : milestone, 18457000,
iast_GLOBAL (18.056 s) : 18056000, 18056000
. : milestone, 18056000,
profiling (14.635 s) : 14635000, 14635000
. : milestone, 14635000,
tracing (14.946 s) : 14946000, 14946000
. : milestone, 14946000,
|
sarahchen6
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Added missing configuration and applied
spotlessto:buildSrcmodule.Motivation
Clean code.
Additional Notes
Spotlessplugin was present before, but as we migrating toKotlinit should be configured.