fix: issues encountered when creating a custom node #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtydhr88
reviewed
Aug 13, 2025
| - name: 📦 Publish Custom Node | ||
| uses: Comfy-Org/publish-node-action@main | ||
| with: | ||
| personal_access_token: {% raw %}${{ secrets.REGISTRY_ACCESS_TOKEN }}{% endraw %} |
Contributor
Author
There was a problem hiding this comment.
perhaps the templating engine changed in new versions of cookiecutter. I was getting the {% raw %} plaintext printed out after templating the new repo.
christian-byrne
approved these changes
Aug 19, 2025
Contributor
|
@jtydhr88 It seems that when we added the react extension template option, we added the Because *.yml is now listed, all YAML files are copied verbatim. Cookiecutter/Jinja never runs on them, so Do we need jinja interpolations on the yaml files? If so, should we remove that from the config? If not, then we can just merge this PR. |
Contributor
|
good catch @christian-byrne I will take look at it, give you back soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a new custom node and encountered some minor issues from the cookiecutter output. This PR should fix those issues.