Skip to content

Commit 1f45351

Browse files
Merge pull request #10 from Comfy-Org/luke/fix-issues
fix: issues encountered when creating a custom node. Note, yaml templating is currently turned off which this PR addresses. See comment for more context: #10 (comment)
2 parents 77a66d0 + fcf59a7 commit 1f45351

File tree

3 files changed

+13
-10
lines changed

3 files changed

+13
-10
lines changed

{{cookiecutter.project_slug}}/common/pyproject.toml

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ authors = [
1111
]
1212
readme = "README.md"
1313
license = {text = "{{cookiecutter.open_source_license}}"}
14+
requires-python = ">=3.10"
1415
classifiers = []
1516
dependencies = [
1617

@@ -29,20 +30,23 @@ dev = [
2930
]
3031

3132
[project.urls]
32-
bugs = "https://github.com/{{cookiecutter.__gh_slug}}/issues"
33-
homepage = "https://github.com/{{cookiecutter.__gh_slug}}"
33+
Repository = "https://github.com/{{cookiecutter.__gh_slug}}"
34+
BugTracker = "https://github.com/{{cookiecutter.__gh_slug}}/issues"
35+
Documentation = "https://github.com/{{cookiecutter.__gh_slug}}/wiki"
3436

3537

3638
[tool.comfy]
3739
PublisherId = "{{cookiecutter.github_username}}"
3840
DisplayName = "{{cookiecutter.project_name}}"
3941
Icon = ""
42+
Tags = []
43+
Repository = "https://github.com/{{cookiecutter.__gh_slug}}"
4044
{% if cookiecutter.frontend_type == 'react' -%}
4145
includes = ["dist/"]
42-
{%- endif %}
43-
44-
{% if cookiecutter.frontend_type == 'vue' -%}
46+
{%- elif cookiecutter.frontend_type == 'vue' -%}
4547
includes = ["js"]
48+
{%- else %}
49+
includes = []
4650
{%- endif %}
4751

4852
[tool.setuptools.package-data]

{{cookiecutter.project_slug}}/custom-nodes-template/.github/workflows/build-pipeline.yml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
# GitHub CI build pipeline
2-
name: {{ cookiecutter.project_slug }} CI build
1+
name: CI build
32

43
on:
54
pull_request:
@@ -8,7 +7,7 @@ on:
87
- main
98
jobs:
109
build:
11-
runs-on: {% raw %} ${{ matrix.os }} {% endraw %}
10+
runs-on: ${{ matrix.os }}
1211
env:
1312
PYTHONIOENCODING: "utf8"
1413
strategy:
@@ -21,7 +20,7 @@ jobs:
2120
- name: Set up Python
2221
uses: actions/setup-python@v5
2322
with:
24-
python-version: {% raw %} ${{ matrix.python-version }} {% endraw %}
23+
python-version: ${{ matrix.python-version }}
2524
- name: Install dependencies
2625
run: |
2726
python -m pip install --upgrade pip

{{cookiecutter.project_slug}}/custom-nodes-template/.github/workflows/publish_node.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,4 @@ jobs:
1818
- name: 📦 Publish Custom Node
1919
uses: Comfy-Org/publish-node-action@main
2020
with:
21-
personal_access_token: {% raw %}${{ secrets.REGISTRY_ACCESS_TOKEN }}{% endraw %}
21+
personal_access_token: ${{ secrets.REGISTRY_ACCESS_TOKEN }}

0 commit comments

Comments
 (0)