msglist: Rename (unknown channel) and (unknown user) #2039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR removes parentheses from the "unknown channel" and "unknown user" labels to align with mainstream app UI conventions (iPhone, Truecaller, WhatsApp), which use plain fallback labels without parentheses.
- Removed parentheses from "unknown channel" and "unknown user" strings
- Updated main localization file and all generated localization files
Reviewed changes
Copilot reviewed 1 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| assets/l10n/app_en.arb | Updated source English localization strings for unknown channel and user names |
| lib/generated/l10n/zulip_localizations.dart | Updated documentation comments for the generated localization methods |
| lib/generated/l10n/zulip_localizations_en.dart | Updated English localization implementation |
| lib/generated/l10n/zulip_localizations_ar.dart | Updated Arabic localization implementation |
| lib/generated/l10n/zulip_localizations_el.dart | Updated Greek localization implementation |
| lib/generated/l10n/zulip_localizations_es.dart | Updated Spanish localization implementation |
| lib/generated/l10n/zulip_localizations_fr.dart | Updated French localization implementation |
| lib/generated/l10n/zulip_localizations_he.dart | Updated Hebrew localization implementation |
| lib/generated/l10n/zulip_localizations_hu.dart | Updated Hungarian localization implementation |
| lib/generated/l10n/zulip_localizations_nb.dart | Updated Norwegian Bokmål localization implementation |
| lib/generated/l10n/zulip_localizations_sk.dart | Updated Slovak localization implementation |
| lib/generated/l10n/zulip_localizations_zh.dart | Updated Chinese localization implementation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
| }, | ||
| "unknownUserName": "(unknown user)", | ||
| "unknownUserName": "unknown user", |
There was a problem hiding this comment.
Inconsistent capitalization: unknownChannelName is capitalized as "Unknown channel" while unknownUserName is lowercase as "unknown user". For consistency, both should use the same capitalization style. Consider changing this to "Unknown user" to match "Unknown channel".
Suggested change
| "unknownUserName": "unknown user", | |
| "unknownUserName": "Unknown user", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2035.
After investigation of several mainstream app and their UI like IPhone's Phone UI(caller id display), Truecaller(for hidden and private numbers) and Whatsapp(For showing Unknown caller's name), they uses plain fallback label like “Unknown …” (no parentheses).