ziggify the generated type bindings #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `types.getRequestMetadata(method)` -> `types.requests.get(method)` - `types.getNotificationMetadata(method)` -> `types.notifications.get(method)` - `types.request_metadata` -> `types.requests.values()` - `types.notification_metadata` -> `types.notifications.values()`
- convert PascalCase to snake_case - better name for array types
That are broken anyway
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #28 +/- ##
==========================================
+ Coverage 97.32% 98.94% +1.62%
==========================================
Files 3 3
Lines 1570 1519 -51
==========================================
- Hits 1528 1503 -25
+ Misses 42 16 -26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the symbols of the LSP specification are in a single namespace which doesn't fit well with the Zig Style Guide. So this PR rewrites the code generation to create bindings with manually chosen names that make better use of namespacing and avoid redundancy in names.
Here are some examples of how the symbol names have changed:
CompletionItem->completion.ItemSemanticTokensRangeParams->semantic_tokens.Params.RangeWorkspaceFoldersChangeEvent->workspace.folders.ChangeEventCreateFileOptions->WorkspaceEdit.CreateFile.OptionsParameterInformation->SignatureHelp.Signature.ParameterClientFoldingRangeOptions->ClientCapabilities.TextDocument.FoldingRange.OptionsThe difference can be easily noticed by looking at the generated documentation from Autodoc:
Zig Autodoc of lsp-kit (old)
Zig Autodoc of lsp-kit (new)
The original names from the LSP specification can still be used from the
@import("lsp").types.flatnamespace if preferred.There are also various other improvements. Here are some of them I can recall:
DeclarationandDefinition