Fix runnable detection #234
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In PR zed-extensions#229, we changed the runnable detection logic for it, describe, its, etc. to look inside of strings for their content so that we don't pass along their quotations to the command line. However, in doing so, tests that use modules, classes, or symbols were no longer being detected. Add back detection for those, and a catch-all to make sure we don't miss any other cases (which is what we had before).
Contributor
Author
|
For any curious internet wanderers that run in to the same problem as me, until this is merged, you can install version 0.16.3 (Extensions -> Search for "Ruby" -> Three dots -> Install another version...) and it should behave the same as before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #229 , we changed the runnable detection logic for it, describe, its, etc. to look inside of strings for their content so that we don't pass along their quotations to the command line. However, in doing so, tests that use modules, classes, or symbols were no longer being detected. Add back detection for those, and a catch-all to make sure we don't miss any other cases (which is what we had before).