-
Notifications
You must be signed in to change notification settings - Fork 131
remove not needed renderer #460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,8 +5,8 @@ | |
| "scripts": { | ||
| "dev-rsbuild": "rsbuild dev", | ||
| "dev-proxy": "node server.js", | ||
| "start": "run-p dev-proxy dev-rsbuild watch-mesher", | ||
| "start2": "run-p dev-rsbuild watch-mesher", | ||
| "start": "run-p dev-proxy dev-rsbuild", | ||
| "start2": "run-p dev-rsbuild", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bug: Lint script references removed
|
||
| "start-metrics": "ENABLE_METRICS=true rsbuild dev", | ||
| "build": "pnpm build-other-workers && rsbuild build", | ||
| "build-analyze": "BUNDLE_ANALYZE=true rsbuild build && pnpm build-other-workers", | ||
|
|
@@ -25,14 +25,6 @@ | |
| "storybook": "storybook dev -p 6006", | ||
| "build-storybook": "storybook build && node scripts/build.js moveStorybookFiles", | ||
| "start-experiments": "vite --config experiments/vite.config.ts --host", | ||
| "watch-other-workers": "echo NOT IMPLEMENTED", | ||
| "build-other-workers": "echo NOT IMPLEMENTED", | ||
| "build-mesher": "node renderer/buildMesherWorker.mjs", | ||
| "watch-mesher": "pnpm build-mesher -w", | ||
| "run-playground": "run-p watch-mesher watch-other-workers watch-playground", | ||
| "run-all": "run-p start run-playground", | ||
| "build-playground": "rsbuild build --config renderer/rsbuild.config.ts", | ||
| "watch-playground": "rsbuild dev --config renderer/rsbuild.config.ts", | ||
| "update-git-deps": "tsx scripts/updateGitDeps.ts", | ||
| "request-data": "tsx scripts/requestData.ts" | ||
| }, | ||
|
|
@@ -89,6 +81,7 @@ | |
| "mcraft-fun-mineflayer": "^0.1.23", | ||
| "minecraft-data": "3.98.0", | ||
| "minecraft-protocol": "github:PrismarineJS/node-minecraft-protocol#master", | ||
| "minecraft-renderer": "^0.1.5", | ||
| "mineflayer-item-map-downloader": "github:zardoy/mineflayer-item-map-downloader", | ||
| "mojangson": "^2.0.4", | ||
| "net-browserify": "github:zardoy/prismarinejs-net-browserify", | ||
|
|
@@ -163,7 +156,6 @@ | |
| "path-browserify": "^1.0.1", | ||
| "path-exists-cli": "^2.0.0", | ||
| "process": "github:PrismarineJS/node-process", | ||
| "renderer": "link:renderer", | ||
| "rimraf": "^5.0.1", | ||
| "storybook": "^7.4.6", | ||
| "stream-browserify": "^3.0.0", | ||
|
|
@@ -202,6 +194,7 @@ | |
| "buffer": "^6.0.3", | ||
| "vec3": "0.1.10", | ||
| "three": "0.154.0", | ||
| "@types/three": "0.154.0", | ||
| "diamond-square": "github:zardoy/diamond-square", | ||
| "prismarine-block": "github:zardoy/prismarine-block#next-era", | ||
| "prismarine-world": "github:zardoy/prismarine-world#next-era", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Build script references removed
build-other-workersscriptThe
buildandbuild-analyzescripts referencepnpm build-other-workers, but this PR removes thebuild-other-workersscript definition (which was"echo NOT IMPLEMENTED"). Runningpnpm buildwill now fail because thebuild-other-workersscript no longer exists.