Skip to content

Conversation

@bernhardkaindl
Copy link
Contributor

@bernhardkaindl bernhardkaindl commented Nov 15, 2024

Now, pyright is ready to replace pyre (obsolete):

The short summary is:

  • It mostly removes obsolete pyre suppressions and replaces pyre with pyright
  • The only changes in xcp/ are removed pyre-suppressions and a safe typing comment for pyright.

Full summary:

  • As the preparations are complete, activate use pyright (Python analsyis server of VS Code)
  • Retire pyre (Facebook's Python static analysis tool):
    • It's not as good as inferring types as Pyright, needs a lot of hand-holding and suppressions.
    • It is many times slower than Pyight
    • It is not integrated into any IDEs (or at least not as well as Pyright, used in VS Code)

As pyre is inferior in every aspect, replace it with Pyright (already used in pre-commit):

  • tox.ini: Complete the transition from pyre to pyright
  • pre-commit: Remove the remaining call to pyre in pre-commit
  • docs: Complete the transition from pyre to pyright
  • tox.ini/pyright: Fail tox if pyright fails (enforce check)
  • Cleanup the obsolete pyre-error suppressions
  • Fix remaining pyright errors and warnings

@bernhardkaindl bernhardkaindl changed the title CI PR #2: Fix GitHub CI and add checks to compensate for code coverage CI PR #5: Fix GitHub CI and add checks to compensate for code coverage Nov 15, 2024
@coveralls
Copy link

coveralls commented Nov 15, 2024

Pull Request Test Coverage Report for Build 11861101564

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 12 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.009%) to 83.661%

Files with Coverage Reduction New Missed Lines %
xcp/accessor.py 1 89.1%
xcp/xmlunwrap.py 2 92.31%
xcp/cpiofile.py 3 75.26%
xcp/compat.py 6 78.57%
Totals Coverage Status
Change from base Build 9109272969: -0.009%
Covered Lines: 2806
Relevant Lines: 3354

💛 - Coveralls

@bernhardkaindl bernhardkaindl force-pushed the ci-finnish-pyre-enforce-pyright branch from 88ad644 to b575246 Compare August 15, 2025 10:01
@bernhardkaindl bernhardkaindl changed the title CI PR #5: Complete the transition from pyre to pyright Remaining CI-fixes PR #1: Transition from pyre to pyright Aug 15, 2025
@bernhardkaindl bernhardkaindl changed the title Remaining CI-fixes PR #1: Transition from pyre to pyright CI-fixes PR #1: pyright is ready to replace pyre (obsolete) Aug 15, 2025
@bernhardkaindl bernhardkaindl requested review from chunjiez and rosslagerwall and removed request for freddy77 August 15, 2025 11:07
@bernhardkaindl bernhardkaindl changed the title CI-fixes PR #1: pyright is ready to replace pyre (obsolete) CI-fixes PR #1: pyright is ready to replace pyre Aug 15, 2025
@bernhardkaindl bernhardkaindl merged commit 4d428f5 into master Aug 15, 2025
7 checks passed
@bernhardkaindl bernhardkaindl deleted the ci-finnish-pyre-enforce-pyright branch September 26, 2025 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants