Remove tools no longer distributed in 2027 #534
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sciencewhiz
reviewed
May 31, 2025
| TextTotal = "Creating Shortcuts"; | ||
| await RunShortcutCreator(token); | ||
| if (token.IsCancellationRequested) break; | ||
| ProgressTotal = 99; |
Contributor
There was a problem hiding this comment.
These two lines can be deleted too
Contributor
|
I was playing around with this, and there's more changes necessary to get it to work with the 2027 version of gradlerio. The problem is that the tools are still referenced in the 2027 gradlerio, but there's no artifacts, and gradleriobase downloads all the tools defined by gradlerio. I tried to add them to skipTools, but couldn't seem to get that working. The right fix is to remove them from gradlerio. Also the choreo cleanup removal should also be in main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.