Fix FileLoaderTask export ambiguity by importing from source in tests #152
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
FileLoaderTaskclass name collision between browser and server implementations caused ambiguous export errors during testing when both environments were loaded through conditional package exports.Changes
FileLoaderTask.test.ts: imports from@workglow/tasks/src/task/FileLoaderTaskFileLoaderTask.server.test.ts: imports from@workglow/tasks/src/task/FileLoaderTask.serverContext
The server implementation extends the base class and overrides it in the TaskRegistry (both share
static type = "FileLoaderTask"). This allows environment-specific implementations without code changes.During testing, when both test files were loaded, the conditional package exports caused ambiguous exports. By importing directly from source files, the tests explicitly choose which implementation to use, bypassing the export resolution issue while maintaining the original class names.
The server implementation delegates HTTP/HTTPS URLs to the parent class while handling file:// URLs with Node.js filesystem APIs.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.