Skip to content

Conversation

@iangmaia
Copy link
Contributor

@iangmaia iangmaia commented Dec 15, 2025

What does it do?

Closes AINFRA-1649.

See p1765809510712929-slack-C02KLTL3MKM.

We've noticed the following error in CI:

sh: 1: source: not found

When running in CI. This PR replaces the source command with ., which is POSIX compliant and should be more portable.

Checklist before requesting a review

  • Run bundle exec rubocop to test for code style violations and recommendations.
  • Add Unit Tests (aka specs/*_spec.rb) if applicable.
  • Run bundle exec rspec to run the whole test suite and ensure all your tests pass.
  • Make sure you added an entry in the CHANGELOG.md file to describe your changes under the appropriate existing ### subsection of the existing ## Trunk section.
  • If applicable, add an entry in the MIGRATION.md file to describe how the changes will affect the migration from the previous major version and what the clients will need to change and consider.

@iangmaia iangmaia self-assigned this Dec 15, 2025
@iangmaia iangmaia added the bug Something isn't working label Dec 15, 2025
@iangmaia iangmaia marked this pull request as ready for review December 15, 2025 18:54
@iangmaia iangmaia changed the title Use . for sourcing env files for POSIX compliant Use . for sourcing env files for POSIX compliance Dec 15, 2025
@iangmaia iangmaia changed the title Use . for sourcing env files for POSIX compliance buildkite_pipeline_upload: use . for sourcing env files for POSIX compliance Dec 15, 2025
@iangmaia iangmaia merged commit a42d5c9 into trunk Dec 15, 2025
9 of 10 checks passed
@iangmaia iangmaia deleted the iangmaia/use-posix-compliant-source branch December 15, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants