Skip to content

Ensure spans validity when getting text copy #1099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zwarm merged 2 commits into from
Feb 18, 2025
Merged

Ensure spans validity when getting text copy #1099

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61dfcc5
Ensure spans safety.
khaykov Feb 17, 2025
5f1e7d9
Merge branch 'trunk' into issue/ensure-valid-spans-when-getting-text-…
khaykov Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions aztec/src/main/kotlin/org/wordpress/aztec/AztecText.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,14 +450,17 @@ open class AztecText : AppCompatEditText, TextWatcher, UnknownHtmlSpan.OnUnknown
*/
fun getTextCopy(): Editable {
val copy = SpannableStringBuilder(text.toString())

val spans: Array<Any> = text.getSpans(0, text.length, Any::class.java)

for (span in spans) {
val spanStart = text.getSpanStart(span)
val spanEnd = text.getSpanEnd(span)
val flags = text.getSpanFlags(span)
copy.setSpan(span, spanStart, spanEnd, flags)

// Only set the span if both start and end positions are valid
if (spanStart >= 0 && spanEnd >= 0) {
val flags = text.getSpanFlags(span)
copy.setSpan(span, spanStart, spanEnd, flags)
}
}
return copy
}
Expand Down