Compiler automatically null terminates #194
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anhu
requested review from
wolfSSL-Bot
and removed request for
JacobBarthelmeh
There was a problem hiding this comment.
Pull request overview
This PR removes redundant explicit null terminators from string literal initializations in two key generation functions. The compiler automatically null-terminates string literals in C, making the explicit \0 characters unnecessary and potentially confusing.
Changes:
- Removed explicit null terminators from
.privand.pubfile extension strings inwolfCLU_genKey_Dilithium - Removed explicit null terminators from
.privand.pubfile extension strings inwolfCLU_genKey_ML_DSA
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dgarske
approved these changes
Jan 15, 2026
dgarske
requested review from
JacobBarthelmeh
and removed request for
wolfSSL-Bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.