test(WPB-19964): add regression tests for message reactions #20232

JacquelineLehner · 2026-01-26T09:54:18Z

WPB-19964 [Web/QA] Write the Reactions regression tests in Playwright

https://wearezeta.atlassian.net/browse/WPB-19964

Pull Request

Summary

Add regression tests for reactions on messages and assets

Security Checklist (required)

External inputs are validated & sanitized on client and/or server where applicable.
API responses are validated; unexpected shapes are handled safely (fallbacks or errors).
No unsafe HTML is rendered; if unavoidable, sanitization is applied and documented where it happens.
Injection risks (XSS/SQL/command) are prevented via safe APIs and/or escaping.

Accessibility (required)

I have read and this PR upholds our Accessibility Best Practices.

Standards Acknowledgement (required)

I have read and this PR upholds our Coding Standards and Tech Radar Choices.

Note for reviewers

Code duplication cannot be reduced any further because it only refers to signing in users.

codecov · 2026-01-26T09:57:53Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.18%. Comparing base (d17b181) to head (b8c8fc5).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files

@@           Coverage Diff           @@
##              dev   #20232   +/-   ##
=======================================
  Coverage   45.18%   45.18%           
=======================================
  Files        1632     1632           
  Lines       40166    40166           
  Branches     8301     8301           
=======================================
  Hits        18150    18150           
  Misses      20090    20090           
  Partials     1926     1926

Flag	Coverage Δ
app_webapp	`43.34% <ø> (ø)`
lib_api_client	`50.27% <ø> (ø)`
lib_core	`58.90% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2026-01-26T10:06:51Z

🔗 Download Full Report Artifact

🧪 Playwright Test Summary

✅ Passed: 142
❌ Failed: 2
⏭ Skipped: 12
🔁 Flaky: 3
📊 Total: 159
⏱ Total Runtime: 79104.9s (~ 1318 min 25 sec)

specs/AppLock/AppLock.spec.ts (❌ 1 failed, ⚠️ 0 flaky)

❌ AppLock > Web: App should not lock if I switch back to webapp tab in time (during inactivity timeout) (tags: TC-2752, TC-2753, regression)

specs/ArchiveSpecs/archive.spec.ts (❌ 0 failed, ⚠️ 1 flaky)

⚠️ Accessibility > I want to archive the 1on1 conversation from conversation details (tags: TC-105, regression)

specs/Authentication/authentication.spec.ts (❌ 0 failed, ⚠️ 1 flaky)

⚠️ Authentication > Make sure user does not see data of user of previous sessions on same browser (tags: TC-1311, regression)

specs/Reactions/reactions.spec.ts (❌ 0 failed, ⚠️ 1 flaky)

⚠️ Reactions > Verify likes are reset if you edited message (tags: TC-1538, regression)

specs/Reply/reply.spec.ts (❌ 1 failed, ⚠️ 0 flaky)

❌ Reply > I should not be able to reply to a ping (tags: TC-8038, regression)

Copilot

Pull request overview

Adds Playwright E2E regression coverage for message reactions across different message/asset types and interaction modes, plus a small enhancement to the conversation page object to support these tests.

Changes:

Introduces Reactions/reactions.spec.ts with regression tests for adding/removing reactions on links, media assets, files, locations, own messages, and system messages.
Verifies reaction UX details such as reaction pill counts, aria-pressed state, and reaction tooltips from multiple users’ perspectives.
Extends the ConversationPage page object with a dedicated heart-reaction locator and refines reactOnMessage to map reaction types to the appropriate UI controls more precisely.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
apps/webapp/test/e2e_tests/specs/Reactions/reactions.spec.ts	Adds a suite of Playwright regression tests covering heart/thumbs-up reactions on various message types, reaction lists, toggling via pills and emoji picker, and ensuring system messages remain non-reactable.
apps/webapp/test/e2e_tests/pageManager/webapp/pages/conversation.page.ts	Updates the conversation page object with a reusable heart reaction pill locator and tightens `reactOnMessage` logic so each reaction type triggers only its intended UI control.

apps/webapp/test/e2e_tests/specs/Reactions/reactions.spec.ts

apps/webapp/test/e2e_tests/pageManager/webapp/pages/conversation.page.ts

apps/webapp/test/e2e_tests/specs/Reactions/reactions.spec.ts

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

arjita-mitra · 2026-01-27T10:46:20Z

apps/webapp/test/e2e_tests/specs/Reactions/reactions.spec.ts

+      const tooltip = userAPages
+        .conversation()
+        .page.getByRole('tooltip')
+        .filter({hasText: `${userA.fullName} reacted with`});


filters tooltips using the full English text ${userA.fullName} reacted with which can be localized or have different punctuation/format, this makes the assertion brittle.

Can we assert presence of the username inside the tooltip, not an exact English phrase.

IMHO it's totally fine to use english text within locators, it's done all the time. We're not going to re-test the whole application for each supported language, so english is the default language set for all tests. (Except e.g. a test which might test switching the locale but that's an edge case)

I agree with Mark. What do you think, Arjita?

arjita-mitra · 2026-01-27T10:52:30Z

apps/webapp/test/e2e_tests/specs/Reactions/reactions.spec.ts

+    const editedMessage = userAPages.conversation().getMessage({content: 'Edited Message'});
+    await expect(editedMessage).toBeVisible();
+
+    await expect(reaction).not.toBeVisible();


Storing an element handle for the reaction before the message is edited and later checking that same handle is not visible can be causing stale element problems. The DOM containing that element may be replaced during edit.

// Re-query the reaction on the edited message to avoid stale element handle
await expect(userAPages.conversation().getReactionOnMessage(editedMessage, 'heart')).not.toBeVisible();

This is not an element handle, it's a playwright locator. Locators in playwright are re-querried every time an assertion or action is triggered on them. (See: https://playwright.dev/docs/locators#locating-elements)

arjita-mitra · 2026-01-27T11:03:15Z

apps/webapp/test/e2e_tests/pageManager/webapp/pages/conversation.page.ts

-    this.systemMessages = page.locator(
-      `${selectByDataAttribute('item-message')}${selectByClass('system-message')} ${selectByClass('message-header')}`,
-    );
+    this.systemMessages = page.locator(`${selectByDataAttribute('item-message')}${selectByClass('system-message')}`);


why are you removing ${selectByClass('message-header')}? Now you’re targeting the whole system message container (item-message.system-message) any reason to do that?

To align this locator with the other message-locators. I added now the selector via the attribute send status to make it clearer.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

This commit introduces a new test suite `reactions.spec.ts` to verify message reaction functionality. Implemented scenarios include: - Reacting to various content types: link previews, pictures, audio, video, shared files, and locations (@TC-1527 - @TC-1533). - Reacting to own messages and partner messages in 1:1 chats. - Verifying that system messages cannot be reacted to (@TC-1535). - Verifying reactions are reset when a message is edited (@TC-1538). - Validating reaction tooltips (@TC-1540). - Adding/removing reactions via pills and the emoji picker (@TC-1548, @TC-1549). The `ConversationPage` page object has been updated to support these interactions, specifically: - Added `reactionWithHeartEmoji` locator. - Refactored `reactOnMessage`. Refs: WPB-19964

This commit reactors the reactions regression tests according to review comments. Refs: WPB-19964

sonarqubecloud · 2026-01-28T12:17:22Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

otto-the-bot added type: test 👷 👕 size: M app: webapp labels Jan 26, 2026

JacquelineLehner marked this pull request as ready for review January 26, 2026 10:16

JacquelineLehner requested review from a team and otto-the-bot as code owners January 26, 2026 10:16

Copilot AI review requested due to automatic review settings January 26, 2026 10:16

Copilot started reviewing on behalf of JacquelineLehner January 26, 2026 10:16 View session

JacquelineLehner marked this pull request as draft January 26, 2026 10:19

Copilot AI reviewed Jan 26, 2026

View reviewed changes

JacquelineLehner force-pushed the 19964-reactions-regression-tests branch from 471e4a5 to f18ad32 Compare January 26, 2026 10:21

markbrockhoff reviewed Jan 26, 2026

View reviewed changes

JacquelineLehner force-pushed the 19964-reactions-regression-tests branch from f18ad32 to 946782b Compare January 26, 2026 16:33

markbrockhoff approved these changes Jan 27, 2026

View reviewed changes

JacquelineLehner force-pushed the 19964-reactions-regression-tests branch from 946782b to 839c8af Compare January 27, 2026 08:48

JacquelineLehner marked this pull request as ready for review January 27, 2026 09:27

Copilot AI review requested due to automatic review settings January 27, 2026 09:27

Copilot started reviewing on behalf of JacquelineLehner January 27, 2026 09:28 View session

Copilot AI reviewed Jan 27, 2026

View reviewed changes

arjita-mitra reviewed Jan 27, 2026

View reviewed changes

JacquelineLehner force-pushed the 19964-reactions-regression-tests branch from 839c8af to 621fbf8 Compare January 27, 2026 15:07

Copilot AI review requested due to automatic review settings January 27, 2026 15:09

Copilot started reviewing on behalf of JacquelineLehner January 27, 2026 15:10 View session

Copilot AI reviewed Jan 27, 2026

View reviewed changes

arjita-mitra approved these changes Jan 28, 2026

View reviewed changes

JacquelineLehner added 3 commits January 28, 2026 13:15

test(reactions): add regression tests for message reactions

47cdd7f

This commit reactors the reactions regression tests according to review comments. Refs: WPB-19964

test(reactions): add regression tests for message reactions

63e856a

This commit reactors the reactions regression tests according to review comments. Refs: WPB-19964

test(reactions): add regression tests for message reactions

b8c8fc5

This commit reactors the reactions regression tests according to review comments. Refs: WPB-19964

Copilot AI review requested due to automatic review settings January 28, 2026 12:16

JacquelineLehner force-pushed the 19964-reactions-regression-tests branch from 1a57c82 to b8c8fc5 Compare January 28, 2026 12:16

Copilot started reviewing on behalf of JacquelineLehner January 28, 2026 12:16 View session

Copilot AI reviewed Jan 28, 2026

View reviewed changes

JacquelineLehner merged commit 9de7772 into dev Jan 28, 2026
55 of 59 checks passed

JacquelineLehner deleted the 19964-reactions-regression-tests branch January 28, 2026 12:57

test(WPB-19964): add regression tests for message reactions #20232

test(WPB-19964): add regression tests for message reactions #20232

Conversation

JacquelineLehner commented Jan 26, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request

Summary

Security Checklist (required)

Accessibility (required)

Standards Acknowledgement (required)

Note for reviewers

Uh oh!

codecov bot commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🧪 Playwright Test Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

arjita-mitra Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

markbrockhoff Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

JacquelineLehner Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

arjita-mitra Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

markbrockhoff Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

JacquelineLehner Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

arjita-mitra Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

JacquelineLehner Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

sonarqubecloud bot commented Jan 28, 2026

Quality Gate passed

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

JacquelineLehner commented Jan 26, 2026 •

edited by github-actions bot

Loading

codecov bot commented Jan 26, 2026 •

edited

Loading

github-actions bot commented Jan 26, 2026 •

edited

Loading

JacquelineLehner Jan 27, 2026 •

edited

Loading