Skip to content

Conversation

@emil-wire
Copy link
Contributor

@emil-wire emil-wire commented Jan 19, 2026

TaskWPB-18861 [Web] add filter for unread messages, mentions and replies

Pull Request

Summary

Please see #19769 for the original PR. Because of the monorepo change, I just redid my changes on the new base.


Security Checklist (required)

  • External inputs are validated & sanitized on client and/or server where applicable.
  • API responses are validated; unexpected shapes are handled safely (fallbacks or errors).
  • No unsafe HTML is rendered; if unavoidable, sanitization is applied and documented where it happens.
  • Injection risks (XSS/SQL/command) are prevented via safe APIs and/or escaping.

Accessibility (required)

Standards Acknowledgement (required)


Screenshots or demo (if the user interface changed)

Notes for reviewers

@codecov
Copy link

codecov bot commented Jan 19, 2026

Codecov Report

❌ Patch coverage is 75.77640% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.32%. Comparing base (70f584b) to head (edc0219).

Files with missing lines Patch % Lines
...onversations/TabsFilterButton/TabsFilterButton.tsx 64.51% 19 Missing and 3 partials ⚠️
...onversations/ConversationTabs/ConversationTabs.tsx 60.00% 5 Missing and 1 partial ⚠️
...LeftSidebar/panels/Conversations/Conversations.tsx 78.57% 3 Missing ⚠️
...anels/Conversations/hooks/useDraftConversations.ts 75.00% 3 Missing ⚠️
...ftSidebar/panels/Conversations/utils/draftUtils.ts 40.00% 1 Missing and 2 partials ⚠️
...eftSidebar/panels/Conversations/useSidebarStore.ts 93.33% 0 Missing and 1 partial ⚠️
...s/webapp/src/script/util/useChannelsFeatureFlag.ts 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #20142      +/-   ##
==========================================
+ Coverage   45.09%   45.32%   +0.23%     
==========================================
  Files        1632     1632              
  Lines       40170    40263      +93     
  Branches     8288     8310      +22     
==========================================
+ Hits        18114    18249     +135     
+ Misses      20157    20106      -51     
- Partials     1899     1908       +9     
Flag Coverage Δ
app_webapp 43.51% <75.77%> (+0.27%) ⬆️
lib_api_client 50.27% <ø> (ø)
lib_core 58.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...omponents/InputBar/common/draftState/draftState.ts 45.83% <100.00%> (+4.92%) ⬆️
...ations/ConversationSidebar/ConversationSidebar.tsx 100.00% <ø> (ø)
...ations/TabsFilterButton/TabsFilterButton.styles.ts 100.00% <100.00%> (ø)
.../page/LeftSidebar/panels/Conversations/helpers.tsx 93.10% <100.00%> (+50.24%) ⬆️
apps/webapp/src/script/util/KeyboardUtil.ts 57.44% <100.00%> (+0.92%) ⬆️
...eftSidebar/panels/Conversations/useSidebarStore.ts 95.65% <93.33%> (+6.76%) ⬆️
...s/webapp/src/script/util/useChannelsFeatureFlag.ts 69.44% <75.00%> (+0.69%) ⬆️
...LeftSidebar/panels/Conversations/Conversations.tsx 60.97% <78.57%> (ø)
...anels/Conversations/hooks/useDraftConversations.ts 86.36% <75.00%> (+14.93%) ⬆️
...ftSidebar/panels/Conversations/utils/draftUtils.ts 72.22% <40.00%> (+57.93%) ⬆️
... and 2 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 19, 2026

🔗 Download Full Report Artifact

🧪 Playwright Test Summary

  • Passed: 111
  • Failed: 8
  • Skipped: 12
  • 🔁 Flaky: 4
  • 📊 Total: 135
  • Total Runtime: 594.1s (~ 9 min 54 sec)
specs/AccountSettingsSpecs/accountSettings.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ account settings > I should not be able to change email of user managed by SCIM (tags: TC-60, regression)
specs/AppLock/AppLock.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ AppLock > Web: App should not lock if I switch back to webapp tab in time (during inactivity timeout) (tags: TC-2752, TC-2753, regression)
specs/ArchiveSpecs/archive.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Accessibility > I want to archive the 1on1 conversation from conversation details (tags: TC-105, regression)
specs/Block/block.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ Block: User A and User B are NOT in the same team > Verify you can unblock someone from conversation list options (tags: TC-148, regression)
specs/CriticalFlow/Cells/editMultipartMessage-TC-8786.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ Edit multipart message in a group conversation (tags: crit-flow-cells, regression, TC-8786)
specs/CriticalFlow/Cells/replyingToMultipartMessage-TC-8787.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ Replying to multipart message in a group conversation (tags: crit-flow-cells, regression, TC-8787)
specs/CriticalFlow/Cells/uploadingFileInGroupConversation.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ Uploading an file in a group conversation (tags: crit-flow-cells, regression)
specs/CriticalFlow/joinTeam-TC-8635.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ New person joins team and sets up device (tags: TC-8635, crit-flow-web)
specs/Edit/edit.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Edit > I want to see the last edited text including a timestamp in message detail view if the message has been edited (tags: TC-3563, regression)
specs/RegressionSpecs/block-messages.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ Block specs (tags: TC-141, regression)
specs/Reply/reply.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Reply > I want to reply with mention and tap on the mention in the reply opens the user profile (tags: TC-3016, regression)
specs/SelfDeletingMessages/selfDeletingMessages.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ in search results > I want to see ephemeral messages in the search results (tags: TC-3717, regression)

@aweiss-dev aweiss-dev changed the title feat(Wpb-18861): Selectable tabs, conversation filters 2nd attempt feat(webapp): Selectable tabs, conversation filters 2nd attempt [WPB-18861] Jan 21, 2026
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants