Skip to content

Conversation

@arjita-mitra
Copy link
Contributor

@arjita-mitra arjita-mitra commented Jan 13, 2026

TaskWPB-20913 [Web] Secure & Time-limited Public Links

Pull Request

Summary

  • What did I change and why?
  • Risks and how to roll out / roll back (e.g. feature flags):

Security Checklist (required)

  • External inputs are validated & sanitized on client and/or server where applicable.
  • API responses are validated; unexpected shapes are handled safely (fallbacks or errors).
  • No unsafe HTML is rendered; if unavoidable, sanitization is applied and documented where it happens.
  • Injection risks (XSS/SQL/command) are prevented via safe APIs and/or escaping.

Accessibility (required)

Standards Acknowledgement (required)


Screenshots or demo (if the user interface changed)

Notes for reviewers

  • Trade-offs:
  • Follow-ups (linked issues):
  • Linked PRs (e.g. web-packages):

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
25.0% Duplication on New Code (required ≤ 5%)

See analysis details on SonarQube Cloud

@github-actions
Copy link
Contributor

🔗 Download Full Report Artifact

🧪 Playwright Test Summary

  • Passed: 111
  • Failed: 8
  • Skipped: 12
  • 🔁 Flaky: 4
  • 📊 Total: 135
  • Total Runtime: 443.3s (~ 7 min 23 sec)
specs/Accessibility/Accessibility.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ In collapsed view > I should not lose a drafted message when switching between conversations in collapsed view (tags: TC-51, regression)
specs/AccountSettingsSpecs/accountSettings.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ account settings > I should not be able to change email of user managed by SCIM (tags: TC-60, regression)
specs/AppLock/AppLock.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ AppLock > Web: App should not lock if I switch back to webapp tab in time (during inactivity timeout) (tags: TC-2752, TC-2753, regression)
specs/ArchiveSpecs/archive.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Accessibility > I want to archive the 1on1 conversation from conversation details (tags: TC-105, regression)
specs/CriticalFlow/accountManagement-TC-8639.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ Account Management (tags: TC-8639, crit-flow-web)
specs/CriticalFlow/addMembersToChat-TC-8631.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Team owner adds whole team to an all team chat (tags: TC-8631, crit-flow-web)
specs/CriticalFlow/Cells/editMultipartMessage-TC-8786.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ Edit multipart message in a group conversation (tags: crit-flow-cells, regression, TC-8786)
specs/CriticalFlow/Cells/replyingToMultipartMessage-TC-8787.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ Replying to multipart message in a group conversation (tags: crit-flow-cells, regression, TC-8787)
specs/CriticalFlow/Cells/uploadingFileInGroupConversation.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ Uploading an file in a group conversation (tags: crit-flow-cells, regression)
specs/CriticalFlow/messagesIn1On1-TC-8750.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Messages in 1:1 (tags: TC-8750, crit-flow-web)
specs/CriticalFlow/oneOnOneCall-TC-8754.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ 1:1 Video call with device switch and screenshare (tags: TC-8754, crit-flow-web)
specs/CriticalFlow/personalAccountLifecycle-TC-8638.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ Personal Account Lifecycle (tags: TC-8638, crit-flow-web)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants