-
Notifications
You must be signed in to change notification settings - Fork 45
feat: disable channel creation for personal users (WPB-22618) #4529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
| .let { navigator.navigate(NavigationCommand(it)) } | ||
| }, | ||
| shouldShowChannelPromotion = !isSelfTeamMember, | ||
| shouldShowChannelPromotion = false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't we need to remove the whole core to shouldShowChannelPromotion ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not want to do it since this is a temporary fix and we will revert it.
| SearchUsersAndAppsScreen( | ||
| searchTitle = stringResource(id = R.string.label_new_conversation), | ||
| shouldShowChannelPromotion = shouldShowChannelPromotion, | ||
| shouldShowChannelPromotion = false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not want to do it since this is a temporary fix and we will revert it.



https://wearezeta.atlassian.net/browse/WPB-22618
What's new in this PR?
Issues
Currently, personal users see the option to create a channel, but are prompted to create a team.
When they create a team, they will still not have the possibility to create channels until we have fully rolled out this feature.
Until such time we want to hide this option in the UI for personal users.