Skip to content

Conversation

@bvandersloot-mozilla
Copy link
Contributor

@bvandersloot-mozilla bvandersloot-mozilla commented Nov 20, 2025

This is to support the spec changes in whatwg/html#11540

Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really see how this is testing the difference between the request partition and the response partition.

Or is this only intended to test the ancestor bit for now? For that it looks reasonable and will also help with whatwg/storage#182

} else {
url.hostname = "{{hosts[][]}}";
}
return event.respondWith(fetch(url));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand how this is doing the CORS thing whatwg/html#11540 (comment) discusses. Or is this testing something else?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was trying to validate that the request vs response partition behavior. I was going to do it with top-level sandboxing, but the sandbox blocks localStorage, so I went this way. I can do a cookie-lookup in a sandboxed-partitioned context if that helps.

Adding the CORS headers here though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants