-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Add some testing for ancestor bit behavior #56147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add some testing for ancestor bit behavior #56147
Conversation
annevk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really see how this is testing the difference between the request partition and the response partition.
Or is this only intended to test the ancestor bit for now? For that it looks reasonable and will also help with whatwg/storage#182
| } else { | ||
| url.hostname = "{{hosts[][]}}"; | ||
| } | ||
| return event.respondWith(fetch(url)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand how this is doing the CORS thing whatwg/html#11540 (comment) discusses. Or is this testing something else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was trying to validate that the request vs response partition behavior. I was going to do it with top-level sandboxing, but the sandbox blocks localStorage, so I went this way. I can do a cookie-lookup in a sandboxed-partitioned context if that helps.
Adding the CORS headers here though.
This is to support the spec changes in whatwg/html#11540