-
-
Notifications
You must be signed in to change notification settings - Fork 199
fix(theme/Codeblock): revert the code shadow and enhance the separator line #2931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for rspress-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR reverts the shadow styling on code blocks by changing the --rp-code-block-shadow CSS variable from var(--rp-shadow-1) to none. The changes are applied consistently to both light and dark mode configurations.
Key Changes
- Removed shadow from code blocks in both light and dark mode by setting
--rp-code-block-shadowtonone - Adjusted divider color opacity values for better visual consistency
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/core/src/theme/styles/vars/code-vars.css | Removes code block shadow by setting the shadow variable to none in both light and dark mode |
| packages/core/src/theme/styles/vars/base-vars.css | Adjusts divider color opacity values (increased from 0.2 to 0.25 and 0.1 to 0.12) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Rsdoctor Bundle Diff Analysis
Found 3 projects in monorepo, 3 projects with changes. 📊 Quick Summary
📋 Detailed Reports (Click to expand)📁 nodePath:
📦 Download Diff Report: node Bundle Diff 📁 node_mdPath:
📦 Download Diff Report: node_md Bundle Diff 📁 webPath:
📦 Download Diff Report: web Bundle Diff Generated by Rsdoctor GitHub Action |
Summary
fix(theme/Codeblock): revert the code shadow
Related Issue
Checklist