Skip to content

Conversation

@SoonIter
Copy link
Member

Summary

fix(theme/Codeblock): revert the code shadow

Related Issue

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings December 25, 2025 03:53
@netlify
Copy link

netlify bot commented Dec 25, 2025

Deploy Preview for rspress-v2 ready!

Name Link
🔨 Latest commit 18aef94
🔍 Latest deploy log https://app.netlify.com/projects/rspress-v2/deploys/694cb538acb2b80008169c63
😎 Deploy Preview https://deploy-preview-2931--rspress-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts the shadow styling on code blocks by changing the --rp-code-block-shadow CSS variable from var(--rp-shadow-1) to none. The changes are applied consistently to both light and dark mode configurations.

Key Changes

  • Removed shadow from code blocks in both light and dark mode by setting --rp-code-block-shadow to none
  • Adjusted divider color opacity values for better visual consistency

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/core/src/theme/styles/vars/code-vars.css Removes code block shadow by setting the shadow variable to none in both light and dark mode
packages/core/src/theme/styles/vars/base-vars.css Adjusts divider color opacity values (increased from 0.2 to 0.25 and 0.1 to 0.12)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

Rsdoctor Bundle Diff Analysis

⚠️ Note: The latest commit (c03d863a6b) does not have baseline artifacts. Using commit b93fade4d0 for baseline comparison instead. If this seems incorrect, please wait a few minutes and try rerunning the workflow.

Found 3 projects in monorepo, 3 projects with changes.

📊 Quick Summary
Project Total Size Change
node 9.2 MB -104.0 B (-0.0%)
node_md 1.1 MB -104.0 B (-0.0%)
web 15.0 MB -50.0 B (-0.0%)
📋 Detailed Reports (Click to expand)

📁 node

Path: website/doc_build/diff-rsdoctor/node/rsdoctor-data.json

📌 Baseline Commit: b93fade4d0 | PR: #2925

Metric Current Baseline Change
📊 Total Size 9.2 MB 9.2 MB -104.0 B (-0.0%)
📄 JavaScript 0 B 0 B 0
🎨 CSS 0 B 0 B 0
🌐 HTML 9.2 MB 9.2 MB -104.0 B (-0.0%)
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: node Bundle Diff

📁 node_md

Path: website/doc_build/diff-rsdoctor/node_md/rsdoctor-data.json

📌 Baseline Commit: b93fade4d0 | PR: #2925

Metric Current Baseline Change
📊 Total Size 1.1 MB 1.1 MB -104.0 B (-0.0%)
📄 JavaScript 0 B 0 B 0
🎨 CSS 0 B 0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 1.1 MB 1.1 MB -104.0 B (-0.0%)

📦 Download Diff Report: node_md Bundle Diff

📁 web

Path: website/doc_build/diff-rsdoctor/web/rsdoctor-data.json

📌 Baseline Commit: b93fade4d0 | PR: #2925

Metric Current Baseline Change
📊 Total Size 15.0 MB 15.0 MB -50.0 B (-0.0%)
📄 JavaScript 14.4 MB 14.4 MB -26.0 B (-0.0%)
🎨 CSS 115.4 KB 115.4 KB -24.0 B (-0.0%)
🌐 HTML 0 B 0 B 0
📁 Other Assets 517.0 KB 517.0 KB 0

📦 Download Diff Report: web Bundle Diff

Generated by Rsdoctor GitHub Action

@SoonIter SoonIter changed the title fix(theme/Codeblock): revert the code shadow fix(theme/Codeblock): revert the code shadow and enhance the separator line Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants