fix: render empty nav items correctly not link

[JounQin]

Summary

render empty nav items correctly not link, empty items should already be handlered at

rspress/packages/core/src/theme/components/Nav/NavMenu.tsx

Lines 47 to 60 in b93fade

	return menuItem.items.length > 0 ? (
	<li
	className="rp-nav-menu__item"
	onMouseEnter={handleMouseEnter}
	onMouseLeave={handleMouseLeave}
	onClick={handleMouseEnter}
	>
	{inner}
	{hoverGroup}
	</li>
	) : (
	<li className="rp-nav-menu__item">{inner}</li>
	);
	}

Related Issue

N/A

Checklist

• Tests updated (or not required).
• Documentation updated (or not required).

[netlify]

✅ Deploy Preview for rspress-v2 ready!

Name	Link
🔨 Latest commit	2991dc5
🔍 Latest deploy log	https://app.netlify.com/projects/rspress-v2/deploys/694e8c7f4156c100087e98d1
😎 Deploy Preview	https://deploy-preview-2929--rspress-v2.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[Copilot]

Pull request overview

This PR fixes a bug where navigation items with empty children arrays were incorrectly rendered as links instead of being handled as parent menu items. The fix removes the length check when determining whether an item should be treated as a menu with children, allowing the downstream NavMenuItemWithChildren component (which already handles empty arrays at lines 47-60) to properly render these items.

Key Changes:

• Removed the item.items.length > 0 check from the condition in NavMenuItem, now only checking if items property exists and is an array
• This ensures items with empty children arrays are passed to NavMenuItemWithChildren instead of being incorrectly cast to NavItemWithLink

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[SoonIter]

遇到了什么问题吗，预期是 items: [] 时，<SvgDown className="rp-nav-menu__item__icon" /> 也不会显示

[JounQin]

遇到了什么问题吗，预期是 items: [] 时，<SvgDown className="rp-nav-menu__item__icon" /> 也不会显示

现在 items: [] 时渲染了 NavMenuItemWithLink，没有 link 配置但渲染出了空 link

rspress/packages/core/src/theme/components/Nav/NavMenu.tsx

Line 83 in 96aac43

<Link href={menuItem.link} className="rp-nav-menu__item__container">

menuItem.items.length > 0 的逻辑已经在下面判断了

rspress/packages/core/src/theme/components/Nav/NavMenu.tsx

Line 47 in 96aac43

return menuItem.items.length > 0 ? (

---

@SoonIter 加了个判断 2991dc5

rspress/packages/core/src/theme/components/NavScreen/NavScreenMenuItem.tsx

Line 127 in b93fade

menuItem={item as any}

这里其实 item 就是 NavItemWithLink，直接用 NavScreenMenuItemWithLink 渲染就行了，不用递归 NavScreenMenuItemWithChildren 导致还是用可选链判断

rspress/packages/core/src/theme/components/NavScreen/NavScreenMenuItem.tsx

Line 100 in b93fade

return menuItem.items?.length > 0 ? (