-
Notifications
You must be signed in to change notification settings - Fork 9
mention graph isomorphism in security considerations #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pchampin
wants to merge
1
commit into
main
Choose a base branch
from
security-consideration-graph-isomorphism
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -2182,6 +2182,17 @@ <h2>Security Considerations</h2> | |||||||
| in [[[UNICODE-SECURITY]]] [[UNICODE-SECURITY]] and | ||||||||
| [[[RFC3987]]] [[RFC3987]] Section 8.</p> | ||||||||
|
|
||||||||
| <p> | ||||||||
| <a href="#graph-isomorphism">Comparing</a> graphs, | ||||||||
| <a href="https://www.w3.org/TR/sparql12-query/">querying</a> them, | ||||||||
| or <a href="https://www.w3.org/TR/rdf12-semantics/#simple_entailment_properties">reasoning</a> with them, | ||||||||
| often relies on computing <em>(sub)graph isomorphism</em>, | ||||||||
| which is known to be computationally complex in the worst case. | ||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
| This means that malicious graphs can be constructed to cause RDF implementations to stall or run out of memory. | ||||||||
| Implementations processing graphs from untrusted sources are expected to provide mitigations; | ||||||||
| examples are given in the section on <a data-cite="RDF-CANON#dataset-poisoning">Dataset Poisoning</a> in [[RDF-CANON]]. | ||||||||
| </p> | ||||||||
|
|
||||||||
| <p class="note">These considerations are a more generic form | ||||||||
| of Security Considerations for [[RDF12-TURTLE]], [[RDF12-TRIG]], [[RDF12-N-TRIPLES]], | ||||||||
| and [[RDF12-N-QUADS]].</p> | ||||||||
|
|
||||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to mention that queries can be expensive but there are lots of ways to have expensive queries; better to say they can be expensive and not to focus on a specific situation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This paragraph is not about querying in general, it is about graph isomorphism.
Of course, other factors can make querying complex (or reasoning, for that matter), but then those would be in scope for the corresponding spec (SPARQL-QUERY or RDF-SEMANTICS).
I don't think that the current wording implies that graph isomorphism is the only source of complexity for these tasks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that text groups query with sub-graph isomorphism.
Isomorphism isn't even mentioned in SPARQL query.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.