-
Notifications
You must be signed in to change notification settings - Fork 63
Updated the ack script configuration files #2722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Maybe we should move these to a special dedications subsection and try to merge/shorten them so we can use a single file for all the documents? Not to sound morbid, but what if we need to make other dedications? |
|
If we have two different acknowledgement files, we'll also need to fix the accessibility specification to point to the new one and update its build script to watch for changes. That's why I'd like to get us back to one file if we can. |
|
Here's a possibility for a paragraph we might include after the list of current contributors, leveraging as much of the existing language as seemed appropriate:
|
|
I like the text. My understanding of your proposal is that we would have a single acknowledgment file (and template), ie, all docs would include this text; for epub3.3, we had a separate text referring to Garth for the content and RS, and a separate one for Ben in a11y. Is that correct? I am happy to make that change (from hindsight, it would have been better for EPUB 3.3 as well...). |
Right, the revised text keeps the memorials without making the dedications specific to a particular document/revision number. This way we can carry them forward and use a single file for all the REC documents. |
|
Ok, I am fine with that. I will take care of the update for the PR later today. |
Done in a6304b9 |
|
I wrote it thinking it would go after the list of current contributors; that's why I put "would also like to". If you want it before the list, then that part should be reworded as there's no "also" if there are no acknowledgements before it. |
|
Oops. I changed it by removing "also". (I followed the same order as was in the epub33 spec.) |
|
@sueneu @shiestyle @wareid can you look at this PR? It is mostly editors' stuff, except for the issue of how to handle memorials to Ben and Garth in 3.4 (and possibly onwards). That should not be a purely editors' decision... |
shiestyle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no objection to this.
|
The memorials are lovely, I’m fine with the text and the order of the acknowledgments |
|
No problems raised, comments incorporated, merging. |
I have also generated new acknowledgement files. Some notes
/common(it used to beepub33/common, but we moved the other files, like css and js, into/common. That means the generated acknowledgement files are also there.