Skip to content

refactor(confirmation): simplify approval type and tighten inject typing #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
E66Crisp wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −32
Open

refactor(confirmation): simplify approval type and tighten inject typing #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 1 addition & 16 deletions apps/www/content/3.components/1.chatbot/confirmation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,21 +194,6 @@ export type ToolUIPartApproval
approved: boolean
reason?: string
}
| {
id: string
approved: true
reason?: string
}
| {
id: string
approved: true
reason?: string
}
| {
id: string
approved: false
reason?: string
}
| undefined

export interface ConfirmationContextValue {
Expand All @@ -220,7 +205,7 @@ export const ConfirmationKey: InjectionKey<ConfirmationContextValue>
= Symbol('ConfirmationContext')

export function useConfirmationContext() {
const context = inject<ConfirmationContextValue | null>(ConfirmationKey, null)
const context = inject(ConfirmationKey)
if (!context)
throw new Error('Confirmation components must be used within <Confirmation>')
return context
Expand Down
17 changes: 1 addition & 16 deletions packages/elements/src/confirmation/context.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,21 +13,6 @@ export type ToolUIPartApproval
approved: boolean
reason?: string
}
| {
id: string
approved: true
reason?: string
}
| {
id: string
approved: true
reason?: string
}
| {
id: string
approved: false
reason?: string
}
| undefined

export interface ConfirmationContextValue {
Expand All @@ -39,7 +24,7 @@ export const ConfirmationKey: InjectionKey<ConfirmationContextValue>
= Symbol('ConfirmationContext')

export function useConfirmationContext() {
const context = inject<ConfirmationContextValue | null>(ConfirmationKey, null)
const context = inject(ConfirmationKey)
if (!context)
throw new Error('Confirmation components must be used within <Confirmation>')
return context
Expand Down