Skip to content

Conversation

@jorgenfj
Copy link
Contributor

Added: LineSegment2D and Line2D, and a conversion function from segment to line.

Dusted off geogebra skills to create test cases:
image

@jorgenfj jorgenfj requested a review from Andeshog January 17, 2026 18:35
@codecov
Copy link

codecov bot commented Jan 17, 2026

Codecov Report

❌ Patch coverage is 80.32787% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.08%. Comparing base (e2f9306) to head (73199c1).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
vortex_utils/cpp_test/test_types.cpp 79.54% 0 Missing and 9 partials ⚠️
vortex_utils/include/vortex/utils/types.hpp 82.35% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
- Coverage   83.24%   83.08%   -0.16%     
==========================================
  Files          11       11              
  Lines        1086     1147      +61     
  Branches      523      541      +18     
==========================================
+ Hits          904      953      +49     
- Misses          6        7       +1     
- Partials      176      187      +11     
Flag Coverage Δ
unittests 83.08% <80.32%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
vortex_utils/include/vortex/utils/types.hpp 93.61% <82.35%> (-2.49%) ⬇️
vortex_utils/cpp_test/test_types.cpp 62.58% <79.54%> (+7.85%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@Andeshog Andeshog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jorgenfj jorgenfj merged commit db3e92e into main Jan 19, 2026
4 checks passed
@jorgenfj jorgenfj deleted the feat/line2D-type branch January 19, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants