Perf: Stream conversion from Parquet to Vortex to prevent OOM #6228
+144
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connortsui20
added
changelog/performance
connortsui20
added
changelog/performance
Contributor
|
part of |
github-actions
bot
removed
the
action/benchmark-sql
Contributor
|
triggered benchmarks to make sure it doesn't change something unexpected about the data, otherwise this looks great. |
Signed-off-by: Connor Tsui <[email protected]>
connortsui20
force-pushed
the
ct/p2v-oom
branch
from
d32c3b4 to
fb02ae5
Compare
connortsui20
added
the
action/benchmark-sql
github-actions
bot
removed
the
action/benchmark-sql
Contributor
Author
|
cancelled the SQL benchmarks run since I force pushed over it, running them again now |
Contributor
Benchmarks: TPC-H SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb NVMeSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Statistical and Population GeneticsSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Clickbench on NVMESummary
Detailed Results Table
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the Parquet to Vortex conversion in
vortex-bench/src/conversions.rsto stream the writer instead of collecting everything in memory.Without this, the Clickbench benchmark on single files (where the input Parquet compressed file is 14GB) OOM on an EC2 instance with only 32 (effective 29) GB of memory.
I've confirmed that this change fixes that problem and also makes it a lot faster to convert.
Also renames some functions to be more descriptive.
I think there might be an argument to making these functions available in the
vortextop-level crate too, this seems to be a generally useful thing to have if you have a bunch of Parquet files.