Skip to content

DF Test refactoring #6223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AdamGS merged 5 commits into from
Jan 30, 2026
Merged

DF Test refactoring #6223

AdamGS merged 5 commits into from
Jan 30, 2026
+374 −492

Conversation

@AdamGS
Copy link
Contributor

@AdamGS AdamGS commented Jan 30, 2026 •
edited
Loading

This PR attempts to make DF tests easier to read and write by moving much of the boilerplate into TestSessionContext and using more SQL (where its applicable).

@AdamGS AdamGS requested review from a10y and asubiotto January 30, 2026 13:53
@AdamGS AdamGS added the chore label Jan 30, 2026
@AdamGS
Lint more stuff
9bd90eb 
Signed-off-by: Adam Gutglick <[email protected]>
@AdamGS AdamGS added changelog/chore A trivial change ext/datafusion Relates to the DataFusion integration and removed chore labels Jan 30, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 30, 2026 •
edited
Loading

Merging this PR will not alter performance

✅ 1138 untouched benchmarks
⏩ 1384 skipped benchmarks1

Comparing adamg/df-test-cleanup (ab6aaba) with develop (848fd89)

Open in CodSpeed

Footnotes

  1. 1384 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

a10y
a10y reviewed Jan 30, 2026
View reviewed changes
vortex-datafusion/src/lib.rs Outdated
// Write arrow data into a vortex file.
pub async fn write_arrow_batch<P>(&self, path: P, batch: &RecordBatch) -> anyhow::Result<()>
where
object_store::path::Path: From<P>,
Copy link
Contributor

@a10y a10y Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

into?

Copy link
Contributor Author

@AdamGS AdamGS Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

a10y
a10y approved these changes Jan 30, 2026
View reviewed changes
Copy link
Contributor

@a10y a10y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice

@AdamGS
CR comment
ab6aaba 
Signed-off-by: Adam Gutglick <[email protected]>
@AdamGS AdamGS enabled auto-merge (squash) January 30, 2026 20:36
@AdamGS AdamGS merged commit 469e31f into develop Jan 30, 2026
44 of 46 checks passed
@AdamGS AdamGS deleted the adamg/df-test-cleanup branch January 30, 2026 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@a10y a10y a10y approved these changes

@asubiotto asubiotto Awaiting requested review from asubiotto

Assignees

No one assigned

Labels

changelog/chore A trivial change ext/datafusion Relates to the DataFusion integration

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AdamGS @a10y