performance: Use push_unchecked when building indices for element take in fixedsizedlist take

[robert3005]

Signed-off-by: Robert Kruszewski [email protected]

[codspeed-hq]

CodSpeed Performance Report

Merging this PR will improve performance by 57.72%

_{Comparing rk/fixedsizedlisttake (49f5351) with develop (848fd89)}

Summary

⚡ 20 improved benchmarks
✅ 1118 untouched benchmarks
⏩ 1384 skipped benchmarks¹

Performance Changes

	Mode	Benchmark	BASE	HEAD	Efficiency
⚡	Simulation	take_fsl_nullable_random[16, 1000]	533.6 µs	399.4 µs	+33.62%
⚡	Simulation	take_fsl_nullable_random[1024, 1000]	32.6 ms	22.6 ms	+44.58%
⚡	Simulation	take_fsl_nullable_random[64, 1000]	1.9 ms	1.3 ms	+47.85%
⚡	Simulation	take_fsl_nullable_random[16, 100]	140.7 µs	123.8 µs	+13.62%
⚡	Simulation	take_fsl_nullable_random[1024, 100]	3.1 ms	2 ms	+54.42%
⚡	Simulation	take_fsl_nullable_random[4096, 100]	12.4 ms	8.1 ms	+53.38%
⚡	Simulation	take_fsl_nullable_random[256, 1000]	7.2 ms	4.7 ms	+53.19%
⚡	Simulation	take_fsl_nullable_random[4096, 1000]	131 ms	90.8 ms	+44.32%
⚡	Simulation	take_fsl_nullable_random[256, 100]	796.3 µs	525.6 µs	+51.5%
⚡	Simulation	take_fsl_random[4096, 1000]	138.2 ms	92.7 ms	+49.1%
⚡	Simulation	take_fsl_random[256, 1000]	7.8 ms	4.9 ms	+57.72%
⚡	Simulation	take_fsl_random[64, 1000]	2 ms	1.3 ms	+53.44%
⚡	Simulation	take_fsl_random[1024, 1000]	34.4 ms	23 ms	+49.45%
⚡	Simulation	take_fsl_random[16, 1000]	516.1 µs	366.6 µs	+40.75%
⚡	Simulation	take_fsl_nullable_random[64, 100]	233.6 µs	165.7 µs	+41.02%
⚡	Simulation	take_fsl_random[256, 100]	804.6 µs	519.8 µs	+54.78%
⚡	Simulation	take_fsl_random[1024, 100]	3.1 ms	2 ms	+57.13%
⚡	Simulation	take_fsl_random[64, 100]	220.3 µs	151.8 µs	+45.12%
⚡	Simulation	take_fsl_random[16, 100]	75 µs	59.8 µs	+25.31%
⚡	Simulation	take_fsl_random[4096, 100]	12.7 ms	8.2 ms	+55.62%

Footnotes

1. 1384 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩