feat[btrblocks]: add a dynamic btr blocks compressor #6207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging this PR will not alter performance
Comparing 
Footnotes
|
joseph-isaacs
added
changelog/feature
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
Contributor
Benchmarks: TPC-H SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: Random AccessSummary
|
joseph-isaacs
added
the
do not merge
Contributor
Benchmarks: TPC-H SF=1 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Statistical and Population GeneticsSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Clickbench on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: CompressionSummary
Detailed Results Table
|
joseph-isaacs
force-pushed
the
ji/btrblocks-comp-builder
branch
from
a054b7a to
68c8d87
Compare
Signed-off-by: Joe Isaacs <[email protected]>
Signed-off-by: Joe Isaacs <[email protected]>
Signed-off-by: Joe Isaacs <[email protected]>
Signed-off-by: Joe Isaacs <[email protected]>
Signed-off-by: Joe Isaacs <[email protected]>
Signed-off-by: Joe Isaacs <[email protected]>
joseph-isaacs
force-pushed
the
ji/btrblocks-comp-builder
branch
from
68c8d87 to
1536f8a
Compare
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
Contributor
Benchmarks: FineWeb NVMeSummary
Detailed Results Table
|
joseph-isaacs
commented
Jan 30, 2026
| let compressed_codes = compressor.compress_canonical( | ||
| Canonical::Primitive(codes.to_primitive()), | ||
| ctx.descend(), | ||
| Excludes::int_only(&[IntCode::Dict, IntCode::Sequence]), |
Contributor
Author
There was a problem hiding this comment.
I think we could remove this? Since Seq can check it might succeed (which we didn't before)
Signed-off-by: Joe Isaacs <[email protected]>
Signed-off-by: Joe Isaacs <[email protected]>
a10y
reviewed
Jan 30, 2026
| /// This struct is passed through recursive compression calls to specify | ||
| /// which schemes should be excluded at each level. | ||
| #[derive(Debug, Clone, Copy, Default)] | ||
| pub struct Excludes<'a> { |
Contributor
There was a problem hiding this comment.
it might be nice to make this owned and then this is what gets passed into the schemes? needing to build new_excludes is a bit messy
Contributor
Author
There was a problem hiding this comment.
Wanted to avoid the move/alloc? What would you do instead?
Contributor
|
approach here looks fine overall |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.