Fix critical MCP server bugs preventing tool calls #917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes three critical bugs in the MCP (Model Context Protocol) integration that prevented MCP tools from being available to the LLM: **Bug voideditor#1: MCP server not added to internal list when toggled ON** - Fixed in mcpChannel.ts line 283 - When toggling an MCP server ON, the client connection was created but never stored in this.infoOfClientId[serverName] - This caused tool calls to fail silently because the client reference was missing - Solution: Added this.infoOfClientId[serverName] = clientInfo after creating the client **Bug voideditor#2: Tool naming system used random prefixes** - Fixed in mcpService.ts line 202 and mcpChannel.ts (removed lines 232-234) - Original implementation used random 6-character prefixes (e.g., a1b2c3_read_file) - This made tools unpredictable and harder to debug - Solution: Replaced with consistent server name prefix using __ separator (e.g., filesystem__read_file) - Updated removeMCPToolNamePrefix() in mcpServiceTypes.ts to handle new format - Updated Settings.tsx to use centralized removeMCPToolNamePrefix() helper **Bug voideditor#3: Improved error handling in MCP channel** - Fixed in mcpChannel.ts lines 109-122 - Errors in call() method returned undefined instead of proper error responses - Solution: Return proper MCPToolErrorResponse for callTool command failures **Additional improvements:** - Added comprehensive debug logging in mcpChannel.ts, mcpService.ts, prompts.ts, and chatThreadService.ts - Logging helps diagnose MCP integration issues and confirms tools are properly registered **Testing:** ✅ MCP servers connect and show green status ✅ Tools are registered with predictable names ✅ Tools are callable and work correctly ✅ Tool calls route to the correct MCP server 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes three critical bugs in the MCP (Model Context Protocol) integration that prevented MCP tools from being available to the LLM:
Bug #1: MCP server not added to internal list when toggled ON
Bug #2: Tool naming system used random prefixes
Bug #3: Improved error handling in MCP channel
Additional improvements:
Testing:
✅ MCP servers connect and show green status
✅ Tools are registered with predictable names
✅ Tools are callable and work correctly
✅ Tool calls route to the correct MCP server
🤖 Generated with Claude Code