-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fix: apply source maps for external module stack trace #9152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: apply source maps for external module stack trace #9152
Conversation
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
@vitest/browser
@vitest/browser-playwright
@vitest/browser-preview
@vitest/browser-webdriverio
@vitest/coverage-istanbul
@vitest/coverage-v8
@vitest/expect
@vitest/mocker
@vitest/pretty-format
@vitest/runner
@vitest/snapshot
@vitest/spy
@vitest/ui
@vitest/utils
vitest
@vitest/web-worker
@vitest/ws-client
commit: |
…external_module_stack_trace' into 12-02-fix_apply_source_maps_for_external_module_stack_trace
| this.url = from | ||
| this.resolvedSources = (sources || []).map(s => | ||
| resolve(s || '', from), | ||
| resolve(from, '..', s || ''), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like some mix up. Realized you fixed up on Vite but not here vitejs/vite#20959
|
I tested minimized preact case and source map is off. It looks like the initial stack trace is already different between Node and Vitest https://github.com/hi-ogawa/reproductions/tree/main/vitest-9003-source-map-external |
Description
Resolves #9003
Closes #9047 (supersedes)
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.