feat: add hostAliases support #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copilot finished reviewing on behalf of
juanpicado
November 27, 2025 18:32
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for Kubernetes hostAliases to the Verdaccio Helm chart, enabling users to configure custom DNS resolutions within pods. This is particularly useful when DNS resolution for certain registries (like npmjs) has been removed from clusters, allowing manual IP-to-hostname mappings to be configured.
Key Changes
- Added
hostAliasesconfiguration option tovalues.yamlwith example documentation - Applied
hostAliasesto both deployment and statefulset pod specs - Maintained consistency with existing pod-level configuration patterns
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| charts/verdaccio/values.yaml | Introduces hostAliases configuration field with example showing how to map IP addresses to hostnames |
| charts/verdaccio/templates/statefulset.yaml | Adds conditional rendering of hostAliases to the pod spec when using statefulset deployment type |
| charts/verdaccio/templates/deployment.yaml | Adds conditional rendering of hostAliases to the pod spec when using deployment type |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR add support for
hostAliasesI need this to be able to target npmjs registry which DNS resolution has been dropped from our clusters