Skip to content

Conversation

@Artur-
Copy link
Member

@Artur- Artur- commented Dec 12, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented Dec 12, 2025

Test Results

1 309 files  ±0  1 309 suites  ±0   1h 16m 41s ⏱️ + 1m 33s
9 224 tests ±0  9 156 ✅ ±0  68 💤 ±0  0 ❌ ±0 
9 687 runs  +2  9 611 ✅ +2  76 💤 ±0  0 ❌ ±0 

Results for commit 706a688. ± Comparison against base commit e68ddbd.

This pull request removes 23 and adds 23 tests. Note that renamed tests count towards both.
com.vaadin.flow.server.frontend.CssBundlerTest ‑ conditionalImportsNotHandled
com.vaadin.flow.server.frontend.CssBundlerTest ‑ differentImportSyntaxesSupported
com.vaadin.flow.server.frontend.CssBundlerTest ‑ dollarAndBackslashWorks
com.vaadin.flow.server.frontend.CssBundlerTest ‑ ignoreCommentedRules
com.vaadin.flow.server.frontend.CssBundlerTest ‑ inlineImports_handlesNullNodeModulesFolder
com.vaadin.flow.server.frontend.CssBundlerTest ‑ inlineImports_prefersRelativeOverNodeModules
com.vaadin.flow.server.frontend.CssBundlerTest ‑ inlineImports_resolvesNodeModulesImport
com.vaadin.flow.server.frontend.CssBundlerTest ‑ layerImportsNotHandled
com.vaadin.flow.server.frontend.CssBundlerTest ‑ minifyCss_collapsesWhitespace
com.vaadin.flow.server.frontend.CssBundlerTest ‑ minifyCss_doesNotRemoveContentComment
…
com.vaadin.flow.internal.CssBundlerTest ‑ conditionalImportsNotHandled
com.vaadin.flow.internal.CssBundlerTest ‑ differentImportSyntaxesSupported
com.vaadin.flow.internal.CssBundlerTest ‑ dollarAndBackslashWorks
com.vaadin.flow.internal.CssBundlerTest ‑ ignoreCommentedRules
com.vaadin.flow.internal.CssBundlerTest ‑ inlineImports_handlesNullNodeModulesFolder
com.vaadin.flow.internal.CssBundlerTest ‑ inlineImports_prefersRelativeOverNodeModules
com.vaadin.flow.internal.CssBundlerTest ‑ inlineImports_resolvesNodeModulesImport
com.vaadin.flow.internal.CssBundlerTest ‑ layerImportsNotHandled
com.vaadin.flow.internal.CssBundlerTest ‑ minifyCss_collapsesWhitespace
com.vaadin.flow.internal.CssBundlerTest ‑ minifyCss_doesNotRemoveContentComment
…

♻️ This comment has been updated with latest results.

@mshabarov mshabarov self-requested a review December 15, 2025 12:36
The internal package methods are ok to use during runtime and the FrontendBuildUtils can only be used by the frontend build
@Artur- Artur- force-pushed the move-classfinder-use branch 2 times, most recently from 36c6dad to 788890a Compare December 19, 2025 18:36
@Artur- Artur- force-pushed the move-classfinder-use branch from 788890a to 706a688 Compare December 19, 2025 18:42
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants