Skip to content

Conversation

@mhelaiwa
Copy link
Contributor

@mhelaiwa mhelaiwa commented Oct 16, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

  • Add support for RTL layouts
  • Add a named slot <slot name="thumb" /> to enable the injection of icons inside the thumb

Related documentation PR #813

πŸ“Έ Screenshots (if appropriate)

image

image

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

- Add support for RTL layouts
- Add <slot name="thumb" /> to allow inject icons inside  the thumb
Copy link
Collaborator

@sadeghbarati sadeghbarati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding slot is LGTM, but could you please remove LTR and RTL classes? and keep the previous classes

Also, add the slot to new-york style too

Then run pnpm build:registry in apps/www

@sadeghbarati
Copy link
Collaborator

There is a poll discussion about directional and logical properties

Once other maintainer decides to go with logical properties we can support RTL and LTR without rtl: and ltr: classes

#470

@sadeghbarati sadeghbarati mentioned this pull request Oct 22, 2024
6 tasks
@mhelaiwa
Copy link
Contributor Author

I've created a new PR #835
@sadeghbarati

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants