-
Notifications
You must be signed in to change notification settings - Fork 170
feat(drivers): enhance drivers with typed options for get, set, remove, and list operations via generation
#662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
schplitt
wants to merge
20
commits into
unjs:main
Choose a base branch
from
schplitt:feat/typed-driver-options
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+357
−33
Open
Changes from 9 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
4bd936d
feat(drivers): enhance drivers with typed options for get, set, remov…
schplitt 54244e3
fix: lint
schplitt 5ace236
fix: correct get and set options
schplitt 561aee7
feat(types): implement WithSafeName utility type
schplitt c6df26a
fix: lint
schplitt b094800
feat(types): implement SafeName utility type and refactor getSafeName…
schplitt c9e65ed
chore: apply automated updates
autofix-ci[bot] ed3bff9
refactor(utils): move getSafeName function to gen-drivers
schplitt 79f7c7b
chore: apply automated updates
autofix-ci[bot] 5a5b77a
refactor(types): use only driver name casing for driver options
schplitt 0778cfb
refactor: use generated `GetOptions` inside deno driver
schplitt 60ba7d7
docs: add guide for creating drivers with typed options
schplitt ef7636a
chore: apply automated updates
autofix-ci[bot] 995a569
chore: apply automated updates (attempt 2/3)
autofix-ci[bot] a8ba05f
docs: better structure
schplitt 39455f3
refactor(types): rename driver options to use safe names and add clea…
schplitt 9558f33
docs: add contributing guide for developing drivers in Unstorage
schplitt 05a9600
docs: add clear options
schplitt 4cf481f
docs: add general contribution guide
schplitt 46293c6
chore: apply automated updates
autofix-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not easily doable in runtime to pass
{ 'deno-kv': { ... opts } }, we should instead use{ denoKV: {} }to be easier with JS objects.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PS: We could simplify the interface to the drivers to actually accept a custom option. We can start by denoKV as an example, but then we need to allow actually
tOpts.denoKV.*.Like discussed, inference of name could be in followup PR. This is mainly to document a "bag of possibe options" for get/set/etc
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for continuously having to ask back.
I assume you are talking about another Generic Type Variable?
The type variable should not be restrained to any type (which makes sense)
Inference of name in another PR for sure, inference of options in internal drivers via generic type maybe in this?