Skip to content

Conversation

@mojixcoder
Copy link
Contributor

@mojixcoder mojixcoder commented Nov 17, 2025

Additions:

  • C.isValidIndex

Fix:

  • Return ErrFailed instead of ErrUnknown which is not a standard error code in H3

    The H3 library may always add additional error messages. Error messages not recognized by the application should be treated as E_FAILED.

Upgrades:

  • Upgrade h3 to v4.4.1

@mojixcoder
Copy link
Contributor Author

I also upgraded to v4.4.1, but after running the update script nothing changed.

@mojixcoder mojixcoder changed the title fix: return failed error instead of unknown error feat: add IsValidIndex Nov 17, 2025
@mojixcoder
Copy link
Contributor Author

Can someone run tests please?

@coveralls
Copy link

coveralls commented Dec 1, 2025

Pull Request Test Coverage Report for Build 20011070865

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 19321058736: 0.0%
Covered Lines: 786
Relevant Lines: 786

💛 - Coveralls

@mojixcoder
Copy link
Contributor Author

Fixed coverage issue.

@mojixcoder
Copy link
Contributor Author

lint was complaining about IsValidIndex not having comments, so I added comments to this method.

Copy link
Collaborator

@zachcoleman zachcoleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants