-
Notifications
You must be signed in to change notification settings - Fork 851
naifs-islamic-research-toolkit:0.1.0 #3750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Regarding the two CI warnings:
Both of these JSON files are crucial for the package to function properly. They contain Quranic words mapped to the right font. This PR is ready for review. Thanks! |
saecki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this package! I've left a comment regarding the name.
| @@ -0,0 +1,25 @@ | |||
| [package] | |||
| name = "madinah-mushaf" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This name seems a little too obvious. We try to avoid canonical names so multiple packages serving the same purpose can coexist without an unfair advantage. See: https://github.com/typst/packages/blob/main/docs/manifest.md#naming-rules
|
I changed the name from |
|
Please correct me if I'm wrong, but from my understanding the "madinah/medina mushaf" is a specific copy of the |
|
Alright, that should do it. I renamed it to Thanks for taking the time to review! |
I am submitting
Description:
naifs-islamic-research-toolkitallows users to render authentic Quranic text in Typst using the fonts from the King Fahad Complex for the Printing of the Holy Quran.It supports:
For more details, feel free to visit my GitHub repository.
I have read and followed the submission guidelines and, in particular, I
typst.tomlfile with all required keysREADME.mdwith documentation for my packageLICENSEfile or linked one in myREADME.mdexcluded PDFs or README images, if any, but not the LICENSE