Reduce log verbosity in tests #27540
Conversation
| logging.setLevel("io.trino.connector.CatalogStoreManager", Level.ERROR); | ||
| logging.setLevel("io.trino.server.PluginManager", Level.ERROR); | ||
| logging.setLevel("io.trino.memory.RemoteNodeMemory", Level.ERROR); |
There was a problem hiding this comment.
In theory we could put ERROR as the default level, but that may make reproducing errors harder. Also, it opens a possibility for the code to work in tests, but not work under defaults settings (yes, i know no code semantics should depend on log levels being enabled).
So for every such special measure we should understand -- and document -- why we're doing that. Please add a line of comment for each of these perhaps exemplifying what's too verbose (at the moment of writing).
BTW sometimes we can fix the problem at source. For instance, airlift configuration logs all configured values, but afaict it's disabled in tests.
There was a problem hiding this comment.
also, why not INFO -> WARN, when INFO is too verbose for tests?
| static { | ||
| Logging logging = Logging.initialize(); | ||
| logging.setLevel("org.hibernate.validator.internal.util.Version", Level.ERROR); | ||
| logging.setLevel("Bootstrap", Level.ERROR); |
There was a problem hiding this comment.
default logger used for unnamed io.airlift.bootstrap.Bootstrap instances
...n/src/test/java/io/trino/server/protocol/spooling/TestPreferredQueryDataEncoderSelector.java
Show resolved
Hide resolved
| { | ||
| static { | ||
| Logging logging = Logging.initialize(); | ||
| logging.setLevel("io.trino.bootstrap.exchange", Level.ERROR); |
There was a problem hiding this comment.
| logging.setLevel("io.trino.bootstrap.exchange", Level.ERROR); | |
| // Airlift configuration logs all the properties | |
| logging.setLevel("io.trino.bootstrap.exchange.filesystem", Level.WARN); |
There was a problem hiding this comment.
It would be much more robust to have io.airlift.bootstrap.Bootstrap#quiet initialize from env.
There was a problem hiding this comment.
3 participants
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.