-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Allow naming matrix expansions #10903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…-dvc-matrix-wrmv3t Allow naming matrix expansions
for more information, see https://pre-commit.ci
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10903 +/- ##
==========================================
+ Coverage 90.68% 90.99% +0.31%
==========================================
Files 504 504
Lines 39795 41002 +1207
Branches 3141 3251 +110
==========================================
+ Hits 36087 37309 +1222
- Misses 3042 3051 +9
+ Partials 666 642 -24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thank you for creating this PR. Since this affects Expanding the schema adds maintenance costs. We avoid doing so unless there is a strong demand from the community, has a clear justification, and provides meaningful value. You can keep this PR open and link it in the new issue, so that others can evaluate and provide feedback. In addition, please expand the PR description with more detail about the proposal, including example usage, expected behavior, etc. |
|
Thanks for the quick review! I understand the hesitation about extending the schema. |
|
|
Allow naming matrix expansions
Description
Summary
nametemplate so each combination gets a stable, user-defined suffixMotivation & Use Case
stage@set0_set1…) are opaque for large pipelines."${item.dataset.key}_${item.model.key}"keeps CLI commands (dvc stage list,dvc repro stage@foo_bar) readable and consistent with downstream artefacts.Example dvc.yaml
Example dataset.yaml
Example model.yaml
Replace the call to dvc repro inference@dataset0_model_0 with dvc repro inference@doctamper_testingset_ffdn, which is much better.
Link issue