Kosta's awesome improvements #40
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixing PSQLException error
Need to add a migration to set the default for existing servers. Though currently we're not planning on supporting upgrading from other versions to this one.
-If things end in /, it'll be stripped off making it non-empty anyways -We can't have empty strings in AO
… to feature/prefix * commit '34c611da03a047391278f27f2ba446f0fcfe8e02': Add our internal repos to pick up jenkins-client 0.3.0.p1 Change to use our internal jenkins-client and the idea of prefix Add a default value of /
-Thank you carl for thinking ahead!!!`
…o feature/prefix * commit '4d99a6cd962ae33a5d4c1154bd56fea3e2b494c2': Add SSH Creds. Uses Jenkins Creds plugin.
-Jenkins credentials don't seem to transfer to env which is good
…fetch to feature/prefix * commit '046bc2cb3729f02e927b203b4152fc2f39d20a1e': Remove the fetch. Jenkins GIT seems to grab all the commits anyways
I have no idea why this test passed with stash 3.6 and broke with 3.10.0. It looks like it should have never worked. I am mortified. *shrug*
(Cherry-picked from 39a0259) Kostas: Please review; had conflicts in JenkinsJobXmlFormatter.java.
Make our desired immutable copy *after* setting the templates to correct value, not before. The big mystery, though, is how in the world this ever passed with stash<3.8. Something seems wrong. Note that this fix is made redundant by commit 0ad061b (Updating for compatibility with stash 3.10.0+, 2015-06-16) but still seems to make the code more correct.
…pgrade to feature/prefix * commit '2d471b8214aea497df12442091ad409f35a52166': Another stash 3.11 fix for RepositoryService.getCloneLinks() Update due to Stash renaming: getVetos -> getVetoes Fix simple order of operations logic bug Documentation update Documenting possible known bug Another stash 3.11 fix I missed the first time Updating for stash 3.11 compat Updating plugin sdk and tomcat Updating for compatibility with stash 3.10.0+
-Builds off of jenkins-client 0.3.0:
https://github.com/RisingOak/jenkins-client/tree/0.3.0
-Adds the idea of prefixes which allows for simple folder support
-We don't change the base url because /crumbIssuer is only at the root of host
-Add a maven "repository" which will just be the libs/ folder
… to pal_stashbot_improve * commit 'f89170c564edd7132c0c5d5a1f27e0a1d74bb63f': Add custom jenkins-client build
-Keep the minimum and maximum as hard coded values for now -Minimum is 5 minutes and maximum is 1 week (10080 minutes)
-The default value is -1 which is the current jenkins-level default -The minimum and maximum values are passed in so the user knows what the range is -Not hooked up to Jenkins job configuration yet
We can't show the default value because this value is set on a per-jenkins server basis. Since a user can modify which server they're using, this will require some kind of dynamic modification of the page. In the future, perhaps we can load all the default timeouts for each server (somehow) in the soy template and then react to dropdown changes.
-We take advantage of the Jenkins build timeout plugin https://wiki.jenkins-ci.org/display/JENKINS/Build-timeout+Plugin -To decide on the value, we set the user's setting unless it's -1 and then we just ask the jenkins setting manager for the default -If someone changes the Jenkins-level default, no one is pushed to the new default until they hit save (or someone does a global save)
-Just a basic what is -I embeded the SVG diagrams because atlassian docs aren't clear about image import
…xes to pal_stashbot_improve * commit 'eb99047d54ed1c8f7e388194b984afd74a8d739a': Add a beginner's dialog box 'What is stashbot?' Set some decent defaults for regexes and commands to run Allow for validation + notifications Rewrite documentation with some examples Fix up all the whitespace and indenting Spacing and a few text fixes Expose the tests + artifacts all the time and hide everything else Do some shifting around and grouping of repo-level options
-Expose number of days and number of builds -These are advanced options for verification and publish -Group verification and verify_pr since most of the time PRs aren't that big -The first time we're trying out using default values and maximum values stored in one place
…ry to pal_stashbot_improve * commit 'f94a1b85b3ee936d4d8c51c53114e062060ed970': Add Jenkins build result expiry options Fix formatting on this chunk of code.
-Admin actions moved to bottom -Admin action links are now buttons -Each jenkins config is now a tab so it's easier to see them -New jenkins config is also a tab -Group Stashbot config options
…o pal_stashbot_improve * commit 'ca6a35d15e6e83105bc1ad86ac4a34639437d9c3': Stashbot Admin UI Settings Changes
… to pal_stashbot_improve * commit '41fbc166bf5064077a245cab915e6bfc84a10833': Automatically recreate missing jobs in Jenkins
…tton to pal_stashbot_improve * commit '1e6e9dab619eff8a2a2605ba4220acb9ad2fe847': ITOOLS-16732 Change Submit button ID since it fixes the double click problem
-Adds column to the DB -Adds the text box in the actual Jenkins Server config
-If no global, business as usual -If a global and no repo, just the global -If a global AND a repo, then global && ( repo ) -Needs escaping of labels since it's not straight alphanumerics anymore
…els to pal_stashbot_improve * commit '5b33121130d911446d67751fef62b3e0ded4da7d': Add the global labels to the actual job configs Add label for all Jenkins builds at Global Level
Adds UI button to Jenkins Admin page to launch cleaning.
…_stashbot_improve * commit '02372bfc685fcdfba888106d81e55410a7979c3d': Delete all old jobs from Jenkins.
…n to pal_stashbot_improve * commit 'aa5558658a457d851f5fcb3143f3bfd29b186355': Add dry_run flag to clean-jobs endpoint
-Make it the defautlt! -Add extra info to logging to know it's a dry run (no need to scare log viewing people)
…gging to pal_stashbot_improve * commit 'c3b5502aebd4a19946b55977c17f5b94b431b2c2': Add a dry run option for the UI
…bs to pal_stashbot_improve * commit 'f22b0685fb6474e7cb242379202ad83ace3c369a': Include "unbuilt jobs" in the start message. Fix i8n property label. Bad copy/paste Add "unused job" deletion Add an ending log message
Owner
|
Awesome, thanks Elijah! I will be sure to check this out. Also, if palantir is not maintaining the stash plugins anymore, should we make the terabyte forks the "network root" to avoid confusion? I believe you can elect a different network root node in the repo settings somewhere... |
Owner
|
hmm, actually looks like you might have to file a request with github to move the network root (only deleting the repos would forcibly move the network root, and it is unclear how the new root is chosen) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm certain you don't want to merge this as-is (you already have several of these commits, some of the older ones that make nasty formatting changes should be tossed, etc.), but you probably do want to cherry-pick the relevant portions of Kosta's work. He intended to create this PR for you, but asked that I do so after yesterday's inexplicable blindsiding.
Also, check out the new and improved README on https://github.com/palantir/stashbot. 😃